Introduce edm::Async service, and use it in CUDA and Alpaka modules #44901

makortel · 2024-05-03T16:30:08Z

PR description:

This PR adds edm::async() facility described in #29188, but implemented as a edm::Async service base class and AsyncService implementation (rationale for service-based approach instead of a free function can be found from #44901 (comment)). This PR also replaces the use of cudaStreamAddCallback() with edm::async() accompanied with cudaEventSynchronize(), and makes the CUDA/Alpaka events to be created with cudaEventBlockingSync flag.

Measurements that I showed in CHEP 2023 https://indico.jlab.org/event/459/contributions/11810/ suggested possible 1 % throughput improvement at the HLT (of that time, many things have changed since) over cudaStreamAddCallback(). Earlier studies done with a prototype in cms-patatrack/pixeltrack-standalone#321 that somehow the thread pool with cudaEventSynchronize() used less CPU than cudaStreamAddCallback().

During the CHEP study I also tested polling with cudaEventQuery(), but the "waiting thread pool" approach was more performant.

Another benefit over cudaStreamAddCallback() is that that function "is slated for eventual deprecation and removal", and the "replacement" cudaLaunchHostFunc() does not call the callback function in case of an error in the associated CUDA stream.

Resolves #29188
Resolves cms-sw/framework-team#916

PR validation:

Unit tests in FWCore/Concurrency, HeterogeneousCore/Alpaka{Core,Test}, HeterogeneousCore/CUDA{Utilities,Core,Test} succeed.

The deployment on CUDA and Alpaka modules still needs performance testing

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Possibly to be backported to 14_0_X.

cmsbuild · 2024-05-03T16:30:34Z

cms-bot internal usage

cmsbuild · 2024-05-03T16:38:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44901/40168

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HeterogeneousCore/CUDACore/src/ScopedContext.cc modified in PR(s): New Heterogeneous Memory Pool #37952

cmsbuild · 2024-05-03T16:38:57Z

A new Pull Request was created by @makortel for master.

It involves the following packages:

FWCore/Concurrency (core)
HeterogeneousCore/AlpakaCore (heterogeneous)
HeterogeneousCore/CUDACore (heterogeneous)
HeterogeneousCore/CUDAUtilities (heterogeneous)

@cmsbuild, @makortel, @Dr15Jones, @smuzaffar, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @wddgit, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2024-05-03T16:44:32Z

enable gpu

makortel · 2024-05-03T16:44:37Z

@cmsbuild, please test

cmsbuild · 2024-05-03T21:33:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3cb6f/39230/summary.html
COMMIT: b758c10
CMSSW: CMSSW_14_1_X_2024-05-03-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44901/39230/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3331548
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3331522
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 18
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 39722
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

FWCore/Concurrency/src/async.cc

cmsbuild · 2024-05-06T21:23:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44901/40191

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HeterogeneousCore/CUDACore/src/ScopedContext.cc modified in PR(s): New Heterogeneous Memory Pool #37952

cmsbuild · 2024-06-04T23:12:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44901/40480

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HeterogeneousCore/CUDACore/src/ScopedContext.cc modified in PR(s): New Heterogeneous Memory Pool #37952

cmsbuild · 2024-06-04T23:12:46Z

Pull request #44901 was updated. @fwyzard, @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

cmsbuild · 2024-06-05T05:09:35Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3cb6f/39706/summary.html
COMMIT: ace8492
CMSSW: CMSSW_14_1_X_2024-06-04-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44901/39706/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338833
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 22
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 39718
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

makortel · 2024-06-05T13:09:25Z

Unit test fails in IBs #45101

makortel · 2024-06-05T13:43:56Z

+core

makortel · 2024-06-05T13:44:38Z

+heterogeneous

Based on earlier #44901 (comment), and that on heterogeneous side there were no substantial changes.

cmsbuild · 2024-06-05T13:44:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

makortel · 2024-06-05T13:45:05Z

ignore tests-rejected with ib-failure

rappoccio · 2024-06-06T13:28:50Z

+1

rappoccio · 2024-06-06T13:28:55Z

merge

cmsbuild added this to the CMSSW_14_1_X milestone May 3, 2024

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending heterogeneous-pending labels May 3, 2024

makortel mentioned this pull request May 3, 2024

Consider edm::async() #29188

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels May 3, 2024

cmsbuild added tests-started and removed tests-pending labels May 3, 2024

cmsbuild added tests-approved and removed tests-started labels May 3, 2024

fwyzard reviewed May 4, 2024

View reviewed changes

FWCore/Concurrency/src/async.cc Outdated Show resolved Hide resolved

makortel force-pushed the edmAsync branch from b758c10 to f8322a0 Compare May 6, 2024 21:14

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels May 6, 2024

makortel mentioned this pull request May 6, 2024

Set names to various CMSSW threads #44912

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels May 6, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 4, 2024

cmsbuild added tests-rejected and removed tests-started labels Jun 5, 2024

cmsbuild added core-approved and removed core-pending labels Jun 5, 2024

cmsbuild added fully-signed heterogeneous-approved and removed pending-signatures heterogeneous-pending labels Jun 5, 2024

cmsbuild added tests-approved tests-ib-failure and removed tests-rejected labels Jun 5, 2024

makortel mentioned this pull request Jun 5, 2024

[14_0_X] Introduce edm::Async service, and use it in CUDA and Alpaka modules #45143

Merged

cmsbuild added orp-approved and removed orp-pending labels Jun 6, 2024

cmsbuild merged commit 0fc3cb9 into cms-sw:master Jun 6, 2024
13 of 14 checks passed

cmsbuild mentioned this pull request Jun 7, 2024

[llvm] Update to version 18.1.6 cms-sw/cmsdist#9200

Merged

makortel mentioned this pull request Jul 8, 2024

Avoid releasing WaitingTask too early in case of exception in WaitingThreadPool #45402

Merged

makortel deleted the edmAsync branch July 10, 2024 20:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce edm::Async service, and use it in CUDA and Alpaka modules #44901

Introduce edm::Async service, and use it in CUDA and Alpaka modules #44901

makortel commented May 3, 2024 •

edited

Loading

cmsbuild commented May 3, 2024 •

edited

Loading

cmsbuild commented May 3, 2024

cmsbuild commented May 3, 2024

makortel commented May 3, 2024

makortel commented May 3, 2024

cmsbuild commented May 3, 2024

cmsbuild commented May 6, 2024

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 5, 2024

makortel commented Jun 5, 2024

makortel commented Jun 5, 2024

makortel commented Jun 5, 2024

cmsbuild commented Jun 5, 2024

makortel commented Jun 5, 2024

rappoccio commented Jun 6, 2024

rappoccio commented Jun 6, 2024

Introduce edm::Async service, and use it in CUDA and Alpaka modules #44901

Introduce edm::Async service, and use it in CUDA and Alpaka modules #44901

Conversation

makortel commented May 3, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented May 3, 2024 • edited Loading

cmsbuild commented May 3, 2024

cmsbuild commented May 3, 2024

makortel commented May 3, 2024

makortel commented May 3, 2024

cmsbuild commented May 3, 2024

Comparison Summary

GPU Comparison Summary

cmsbuild commented May 6, 2024

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 5, 2024

Unit Tests

Comparison Summary

GPU Comparison Summary

makortel commented Jun 5, 2024

makortel commented Jun 5, 2024

makortel commented Jun 5, 2024

cmsbuild commented Jun 5, 2024

makortel commented Jun 5, 2024

rappoccio commented Jun 6, 2024

rappoccio commented Jun 6, 2024

makortel commented May 3, 2024 •

edited

Loading

cmsbuild commented May 3, 2024 •

edited

Loading