Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate assert to to ALPAKA_ASSERT_ACC #44802

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 22, 2024

PR description:

Migrate assert() to ALPAKA_ASSERT_ACC().

PR validation:

None.

To be backported to 14.0.x for data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

Fixes #44792.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

urgent

Backport needed for data taking.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

enable gpu

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44802/40045

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • CondFormats/SiPixelObjects (db, alca)
  • DataFormats/SiPixelClusterSoA (reconstruction, heterogeneous)
  • DataFormats/SiPixelDigiSoA (reconstruction, heterogeneous)
  • DataFormats/VertexSoA (reconstruction, heterogeneous)
  • HeterogeneousCore/AlpakaInterface (heterogeneous)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalTracker/SiPixelRecHits (reconstruction)
  • RecoTracker/PixelSeeding (reconstruction)

@fwyzard, @jfernan2, @francescobrivio, @consuegs, @mandrenguyen, @makortel, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks.
@seemasharmafnal, @JanFSchulte, @ReyerBand, @argiro, @missirol, @mmusich, @mtosi, @VinInn, @makortel, @gpetruc, @felicepantaleo, @PonIlya, @yuanchao, @rsreds, @tvami, @wang0jin, @tocheng, @rovere, @dgulhan, @rchatter, @mroguljic, @ferencek, @dkotlins, @thomreis, @youyingli, @GiacomoSguazzoni, @apsallid, @JanChyczynski, @tsusa, @VourMa, @threus this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 22, 2024

+heterogeneous

@fwyzard fwyzard changed the title Migrato assert to to ALPAKA_ASSERT_ACC Migrate assert to to ALPAKA_ASSERT_ACC Apr 22, 2024
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09cbfe/39005/summary.html
COMMIT: 821de17
CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44802/39005/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 39 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319852
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319829
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 32 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1562
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38178
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants