-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reduced lepton time-life info to NanoAOD (14_0_X) #44689
Add reduced lepton time-life info to NanoAOD (14_0_X) #44689
Conversation
A new Pull Request was created by @mbluj for CMSSW_14_0_X. It involves the following packages:
@cmsbuild, @hqucms, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
type tau |
enable nano |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-NANO RelVals-INPUT
RelVals-NANO
Comparison SummarySummary:
|
b3a99a4
to
3328abc
Compare
Pull request #44689 was updated. @miquork, @AdrianoDee, @srimanob, @sunilUIET, @subirsarkar, @cmsbuild, @hqucms, @vlimant can you please check and sign again. |
Rebased to the most recent IB and problematic test wfs adjusted. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd5f91/38782/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
Pull request #44689 was updated. @srimanob, @cmsbuild, @sunilUIET, @hqucms, @vlimant, @AdrianoDee, @miquork, @subirsarkar can you please check and sign again. |
Rebased to solve conflicts, basic tests with nano wf successful - ready for re-testing and eventually merging. |
Thanks a lot @mbluj ! |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd5f91/38858/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 Could you please check and sign? Thanks! |
+Upgrade |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 Could you please merge this? Thanks! |
+1 |
PR description:
This PR adds base lepton time-life info to common (Phys) NanoAOD tables while lepton track parameters can be added through customization.
This is backport of #44637 to 14_0_X; further details in the original PR.
PR validation:
Tested with the standard nanoAOD workflow.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #44637 for 2024 nanoAOD.