Add reduced lepton time-life info to NanoAOD (14_0_X) #44689

mbluj · 2024-04-10T10:31:39Z

PR description:

This PR adds base lepton time-life info to common (Phys) NanoAOD tables while lepton track parameters can be added through customization.
This is backport of #44637 to 14_0_X; further details in the original PR.

PR validation:

Tested with the standard nanoAOD workflow.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44637 for 2024 nanoAOD.

cmsbuild · 2024-04-10T10:31:59Z

A new Pull Request was created by @mbluj for CMSSW_14_0_X.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @hqucms, @vlimant can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-04-10T10:32:00Z

cms-bot internal usage

hqucms · 2024-04-10T15:23:32Z

type tau

hqucms · 2024-04-10T15:23:36Z

enable nano

hqucms · 2024-04-10T15:23:42Z

please test

cmsbuild · 2024-04-10T18:13:39Z

-1

Failed Tests: RelVals-INPUT RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd5f91/38749/summary.html
COMMIT: b3a99a4
CMSSW: CMSSW_14_0_X_2024-04-10-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44689/38749/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

2500.3172500.317_lepTimeLifeNANOdata130Xrun3/step2_lepTimeLifeNANOdata130Xrun3.log
2500.4042500.404_lepTimeLifeNANOmc132X/step2_lepTimeLifeNANOmc132X.log

RelVals-NANO

2500.3172500.317_lepTimeLifeNANOdata130Xrun3/step2_lepTimeLifeNANOdata130Xrun3.log
2500.4042500.404_lepTimeLifeNANOmc132X/step2_lepTimeLifeNANOmc132X.log

Comparison Summary

Summary:

You potentially added 104 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 61 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3350124
DQMHistoTests: Total failures: 1355
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3348747
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 43.38 KiB( 48 files compared)
DQMHistoSizes: changed ( 13234.0,... ): 4.820 KiB Physics/NanoAODDQM
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-04-11T09:05:14Z

Pull request #44689 was updated. @miquork, @AdrianoDee, @srimanob, @sunilUIET, @subirsarkar, @cmsbuild, @hqucms, @vlimant can you please check and sign again.

mbluj · 2024-04-11T09:05:45Z

Rebased to the most recent IB and problematic test wfs adjusted.

hqucms · 2024-04-11T11:55:45Z

please test

cmsbuild · 2024-04-11T14:51:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd5f91/38782/summary.html
COMMIT: 3328abc
CMSSW: CMSSW_14_0_X_2024-04-11-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44689/38782/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 65 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3308451
DQMHistoTests: Total failures: 1358
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3307073
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 43.38 KiB( 47 files compared)
DQMHistoSizes: changed ( 13234.0,... ): 4.820 KiB Physics/NanoAODDQM
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 3 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16470
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16470
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 33.74 KiB( 14 files compared)
DQMHistoSizes: changed ( 2500.011,... ): 4.820 KiB Physics/NanoAODDQM
Checked 45 log files, 25 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.670	2.553	0.117 ( +4.6% )	5.10	5.22	-2.3%	2.234	2.219
2500.001	2.783	2.703	0.080 ( +3.0% )	4.55	4.69	-3.0%	2.661	2.596
2500.002	2.730	2.643	0.087 ( +3.3% )	4.70	4.87	-3.5%	2.649	2.596
2500.01	1.381	1.318	0.063 ( +4.8% )	9.15	9.69	-5.6%	2.355	2.296
2500.011	1.818	1.740	0.079 ( +4.5% )	5.04	5.24	-3.8%	2.545	2.459
2500.012	1.676	1.581	0.096 ( +6.1% )	7.09	7.46	-5.0%	2.374	2.374
2500.1	2.273	2.197	0.076 ( +3.5% )	5.19	5.26	-1.3%	2.075	2.071
2500.2	2.390	2.314	0.075 ( +3.3% )	5.78	6.01	-3.7%	1.985	1.983
2500.21	1.254	1.182	0.072 ( +6.1% )	4.22	4.29	-1.6%	2.277	2.270
2500.211	1.629	1.546	0.083 ( +5.3% )	3.63	3.75	-3.3%	2.349	2.357
2500.3	2.139	2.065	0.075 ( +3.6% )	11.96	12.47	-4.1%	1.980	1.973
2500.301	2.719	2.637	0.082 ( +3.1% )	9.85	10.20	-3.4%	1.964	1.957
2500.31	1.322	1.255	0.068 ( +5.4% )	19.03	19.98	-4.7%	2.359	2.353
2500.311	1.722	1.641	0.081 ( +5.0% )	13.25	13.36	-0.8%	2.460	2.453
2500.312	7.159	7.159	0.000 ( +0.0% )	1.33	1.34	-0.2%	1.694	1.698
2500.313	1.564	1.564	0.000 ( +0.0% )	6.78	6.50	+4.3%	1.055	1.050
2500.314	1.204	1.163	0.041 ( +3.5% )	13.40	13.95	-4.0%	2.273	2.151
2500.315	1.838	1.757	0.081 ( +4.6% )	13.34	14.25	-6.3%	2.340	2.331
2500.316	3.174	3.093	0.081 ( +2.6% )	2.11	2.24	-6.1%	2.289	2.273
2500.317	1.776	1.788	-0.012 ( -0.7% )	12.58	13.75	-8.5%	2.163	2.167
2500.4	2.304	2.226	0.078 ( +3.5% )	11.53	12.14	-5.0%	1.886	1.883
2500.401	1.785	1.749	0.036 ( +2.1% )	9.73	10.47	-7.0%	1.815	1.737
2500.402	2.856	2.770	0.086 ( +3.1% )	9.68	10.16	-4.7%	1.788	1.786
2500.403	5.166	5.080	0.086 ( +1.7% )	1.57	1.61	-2.4%	1.829	1.938
2500.404	2.766	2.778	-0.012 ( -0.4% )	9.61	9.95	-3.3%	1.901	1.902
2500.5	5.192	5.192	0.000 ( +0.0% )	15.65	15.98	-2.1%	1.619	1.627
2500.51	9.119	9.119	0.000 ( +0.0% )	9.67	9.69	-0.2%	1.657	1.660

hqucms · 2024-04-11T15:27:26Z

+1

cmsbuild · 2024-04-15T15:57:38Z

Pull request #44689 was updated. @srimanob, @cmsbuild, @sunilUIET, @hqucms, @vlimant, @AdrianoDee, @miquork, @subirsarkar can you please check and sign again.

mbluj · 2024-04-15T15:59:31Z

Rebased to solve conflicts, basic tests with nano wf successful - ready for re-testing and eventually merging.

hqucms · 2024-04-15T16:04:02Z

Thanks a lot @mbluj !

hqucms · 2024-04-15T16:04:08Z

please test

cmsbuild · 2024-04-15T22:20:27Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd5f91/38858/summary.html
COMMIT: 07f74fb
CMSSW: CMSSW_14_0_X_2024-04-15-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44689/38858/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 19 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 49 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3309849
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3309823
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 43.38 KiB( 47 files compared)
DQMHistoSizes: changed ( 13234.0,... ): 4.820 KiB Physics/NanoAODDQM
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 6 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16484
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16484
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 33.74 KiB( 14 files compared)
DQMHistoSizes: changed ( 2500.011,... ): 4.820 KiB Physics/NanoAODDQM
Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.692	2.575	0.117 ( +4.5% )	4.69	4.83	-2.8%	2.235	2.213
2500.001	2.803	2.722	0.081 ( +3.0% )	4.25	4.41	-3.6%	2.673	2.099
2500.002	2.751	2.667	0.083 ( +3.1% )	4.38	4.54	-3.4%	2.653	2.222
2500.01	1.383	1.320	0.063 ( +4.8% )	8.02	8.61	-6.8%	2.353	2.055
2500.011	1.820	1.742	0.078 ( +4.5% )	4.64	4.85	-4.3%	2.537	2.096
2500.012	1.681	1.583	0.098 ( +6.2% )	6.36	6.76	-6.0%	2.442	2.022
2500.1	2.337	2.259	0.078 ( +3.5% )	5.04	5.03	+0.1%	2.080	1.915
2500.2	2.441	2.366	0.075 ( +3.2% )	5.57	5.83	-4.5%	1.987	1.828
2500.21	1.271	1.200	0.071 ( +5.9% )	4.16	4.17	-0.3%	2.286	1.784
2500.211	1.651	1.568	0.083 ( +5.3% )	3.02	3.10	-2.7%	2.360	1.878
2500.3	2.205	2.132	0.073 ( +3.4% )	11.17	11.27	-0.9%	1.977	1.862
2500.301	2.805	2.723	0.082 ( +3.0% )	6.55	6.26	+4.5%	1.962	1.815
2500.31	1.350	1.281	0.069 ( +5.4% )	17.35	17.92	-3.2%	2.384	2.236
2500.311	1.756	1.676	0.081 ( +4.8% )	7.64	7.14	+7.0%	2.471	2.251
2500.312	7.164	7.164	0.000 ( +0.0% )	0.77	0.80	-2.9%	1.691	1.695
2500.313	1.568	1.568	0.000 ( +0.0% )	1.65	1.71	-3.6%	1.052	1.054
2500.314	1.240	1.199	0.041 ( +3.4% )	7.22	7.29	-1.0%	2.254	1.691
2500.315	1.878	1.797	0.081 ( +4.5% )	6.50	6.98	-6.9%	2.239	1.800
2500.316	3.201	3.120	0.081 ( +2.6% )	1.83	1.99	-7.7%	2.133	1.795
2500.317	1.812	1.824	-0.012 ( -0.7% )	5.91	6.80	-13.1%	2.263	2.120
2500.318	4.286	4.206	0.081 ( +1.9% )	3.49	3.75	-6.8%	2.249	2.139
2500.4	2.383	2.305	0.078 ( +3.4% )	10.37	10.95	-5.3%	1.844	1.820
2500.401	1.885	1.849	0.036 ( +1.9% )	5.65	6.73	-16.1%	1.837	1.681
2500.402	2.957	2.871	0.086 ( +3.0% )	5.58	6.49	-14.1%	1.860	1.838
2500.403	5.266	5.181	0.086 ( +1.7% )	1.39	1.50	-7.3%	1.983	1.829
2500.404	2.867	2.879	-0.012 ( -0.4% )	4.89	5.03	-2.7%	1.757	1.732
2500.405	8.913	8.827	0.086 ( +1.0% )	2.40	2.56	-6.3%	1.806	1.747
2500.5	5.194	5.194	0.000 ( +0.0% )	13.25	13.97	-5.1%	1.699	1.564
2500.51	9.120	9.120	0.000 ( +0.0% )	8.83	9.28	-4.9%	1.633	1.523

hqucms · 2024-04-16T08:26:37Z

+1

hqucms · 2024-04-19T06:44:55Z

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 Could you please check and sign? Thanks!

srimanob · 2024-04-19T06:50:09Z

+Upgrade

AdrianoDee · 2024-04-19T06:52:32Z

+pdmv

cmsbuild · 2024-04-19T06:52:59Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

hqucms · 2024-04-19T11:13:44Z

@cms-sw/orp-l2 Could you please merge this? Thanks!

rappoccio · 2024-04-22T17:57:25Z

+1

cmsbuild added this to the CMSSW_14_0_X milestone Apr 10, 2024

cmsbuild added pending-signatures tests-pending orp-pending xpog-pending labels Apr 10, 2024

cmsbuild added tests-started tau and removed tests-pending labels Apr 10, 2024

cmsbuild added tests-rejected and removed tests-started labels Apr 10, 2024

mbluj force-pushed the CMSSW_14_0_X_tauLifeTimeSplit branch from b3a99a4 to 3328abc Compare April 11, 2024 09:04

cmsbuild added tests-pending pdmv-pending upgrade-pending and removed tests-rejected labels Apr 11, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 11, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 11, 2024

cmsbuild added the xpog-pending label Apr 15, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 15, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 15, 2024

cmsbuild added xpog-approved and removed xpog-pending labels Apr 16, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Apr 19, 2024

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Apr 19, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 22, 2024

cmsbuild merged commit e503e2d into cms-sw:CMSSW_14_0_X Apr 22, 2024
12 checks passed

This was referenced Apr 22, 2024

[14.0.X] Update 2024 geometry and GEM alignment conditions in 2024 MC GTs #44512

Merged

Migrate assert to to ALPAKA_ASSERT_ACC [14.0.x] #44805

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add reduced lepton time-life info to NanoAOD (14_0_X) #44689

Add reduced lepton time-life info to NanoAOD (14_0_X) #44689

mbluj commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

cmsbuild commented Apr 10, 2024 •

edited

Loading

hqucms commented Apr 10, 2024

hqucms commented Apr 10, 2024

hqucms commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

cmsbuild commented Apr 11, 2024

mbluj commented Apr 11, 2024

hqucms commented Apr 11, 2024

cmsbuild commented Apr 11, 2024

hqucms commented Apr 11, 2024

cmsbuild commented Apr 15, 2024

mbluj commented Apr 15, 2024

hqucms commented Apr 15, 2024

hqucms commented Apr 15, 2024

cmsbuild commented Apr 15, 2024

hqucms commented Apr 16, 2024

hqucms commented Apr 19, 2024

srimanob commented Apr 19, 2024

AdrianoDee commented Apr 19, 2024

cmsbuild commented Apr 19, 2024

hqucms commented Apr 19, 2024

rappoccio commented Apr 22, 2024

Add reduced lepton time-life info to NanoAOD (14_0_X) #44689

Add reduced lepton time-life info to NanoAOD (14_0_X) #44689

Conversation

mbluj commented Apr 10, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Apr 10, 2024

cmsbuild commented Apr 10, 2024 • edited Loading

hqucms commented Apr 10, 2024

hqucms commented Apr 10, 2024

hqucms commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

RelVals-INPUT

RelVals-NANO

Comparison Summary

cmsbuild commented Apr 11, 2024

mbluj commented Apr 11, 2024

hqucms commented Apr 11, 2024

cmsbuild commented Apr 11, 2024

Comparison Summary

NANO Comparison Summary

hqucms commented Apr 11, 2024

cmsbuild commented Apr 15, 2024

mbluj commented Apr 15, 2024

hqucms commented Apr 15, 2024

hqucms commented Apr 15, 2024

cmsbuild commented Apr 15, 2024

Comparison Summary

NANO Comparison Summary

hqucms commented Apr 16, 2024

hqucms commented Apr 19, 2024

srimanob commented Apr 19, 2024

AdrianoDee commented Apr 19, 2024

cmsbuild commented Apr 19, 2024

hqucms commented Apr 19, 2024

rappoccio commented Apr 22, 2024

cmsbuild commented Apr 10, 2024 •

edited

Loading