Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit accelerator types in alpaka device code #44636

Closed

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 5, 2024

PR description:

Update the HeterogeneousTest alpaka tests to use the explicit accelerator types in alpaka device code:

  • move all alpaka device code to the ALPAKA_ACCELERATOR_NAMESPACE namespace;
  • use the explicit accelerator types, like Acc1D or Acc2D, instead of the generic TAcc template argument;
  • move the definition of the device code to .dev.cc files and build them as libraries, instead of using a header-only approach.

PR validation:

The new HeterogeneousTest unit tests pass:

Creating test log file logs/el8_amd64_gcc12/testing.log
Skip    0s ... HeterogeneousTest/ROCmWrapper/testRocmDeviceAdditionWrapper (Failed to run rocmIsEnabled)
Skip    0s ... HeterogeneousTest/AlpakaDevice/testAlpakaDeviceAdditionROCmAsync (Failed to run rocmIsEnabled)
Skip    0s ... HeterogeneousTest/AlpakaKernel/testAlpakaDeviceAdditionKernelROCmAsync (Failed to run rocmIsEnabled)
Skip    0s ... HeterogeneousTest/AlpakaOpaque/testAlpakaDeviceAdditionOpaqueROCmAsync (Failed to run rocmIsEnabled)
Skip    0s ... HeterogeneousTest/AlpakaWrapper/testAlpakaDeviceAdditionWrapperROCmAsync (Failed to run rocmIsEnabled)
Pass    0s ... HeterogeneousTest/ROCmDevice/testRocmDeviceAddition
Pass    0s ... HeterogeneousTest/ROCmOpaque/testRocmDeviceAdditionOpaque
Pass    0s ... HeterogeneousTest/ROCmKernel/testRocmDeviceAdditionKernel
Pass    0s ... HeterogeneousTest/AlpakaOpaque/testAlpakaDeviceAdditionOpaqueSerialSync
Pass    0s ... HeterogeneousTest/AlpakaDevice/testAlpakaDeviceAdditionSerialSync
Pass    0s ... HeterogeneousTest/AlpakaKernel/testAlpakaDeviceAdditionKernelSerialSync
Pass    0s ... HeterogeneousTest/AlpakaWrapper/testAlpakaDeviceAdditionWrapperSerialSync
Pass    4s ... HeterogeneousTest/ROCmDevice/testROCmTestDeviceAdditionModule
Pass    5s ... HeterogeneousTest/ROCmOpaque/testROCmTestOpaqueAdditionModule
Pass    5s ... HeterogeneousTest/ROCmWrapper/testROCmTestWrapperAdditionModule
Pass    5s ... HeterogeneousTest/ROCmOpaque/testROCmTestAdditionModules
Pass    5s ... HeterogeneousTest/ROCmKernel/testROCmTestKernelAdditionModule
Pass    9s ... HeterogeneousTest/CUDAWrapper/testCudaDeviceAdditionWrapper
Pass    9s ... HeterogeneousTest/AlpakaWrapper/testAlpakaDeviceAdditionWrapperCudaAsync
Pass    9s ... HeterogeneousTest/AlpakaOpaque/testAlpakaDeviceAdditionOpaqueCudaAsync
Pass    9s ... HeterogeneousTest/CUDAOpaque/testCudaDeviceAdditionOpaque
Pass    9s ... HeterogeneousTest/AlpakaDevice/testAlpakaDeviceAdditionCudaAsync
Pass    9s ... HeterogeneousTest/CUDAKernel/testCudaDeviceAdditionKernel
Pass    9s ... HeterogeneousTest/CUDADevice/testCudaDeviceAddition
Pass    9s ... HeterogeneousTest/AlpakaKernel/testAlpakaDeviceAdditionKernelCudaAsync
Pass   18s ... HeterogeneousTest/CUDAOpaque/testCUDATestOpaqueAdditionModule
Pass   18s ... HeterogeneousTest/CUDADevice/testCUDATestDeviceAdditionModule
Pass   18s ... HeterogeneousTest/AlpakaDevice/testAlpakaTestDeviceAdditionModule
Pass   18s ... HeterogeneousTest/CUDAWrapper/testCUDATestWrapperAdditionModule
Pass   17s ... HeterogeneousTest/AlpakaWrapper/testAlpakaTestWrapperAdditionModule
Pass   17s ... HeterogeneousTest/AlpakaKernel/testAlpakaTestKernelAdditionModule
Pass   17s ... HeterogeneousTest/AlpakaOpaque/testAlpakaTestOpaqueAdditionModule
Pass   17s ... HeterogeneousTest/CUDAKernel/testCUDATestKernelAdditionModule
Pass   18s ... HeterogeneousTest/CUDAOpaque/testCUDATestAdditionModules
Pass   17s ... HeterogeneousTest/AlpakaOpaque/testAlpakaTestAdditionModules
>> Test sequence completed for CMSSW CMSSW_14_1_X_2024-04-04-1100

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 5, 2024

enable gpu

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Apr 5, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 5, 2024

please test with cms-sw/cmsdist#9121

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44636/39823

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • HeterogeneousTest/AlpakaDevice (heterogeneous)
  • HeterogeneousTest/AlpakaKernel (heterogeneous)
  • HeterogeneousTest/AlpakaOpaque (heterogeneous)
  • HeterogeneousTest/AlpakaWrapper (heterogeneous)
  • HeterogeneousTest/CUDADevice (heterogeneous)
  • HeterogeneousTest/CUDAKernel (heterogeneous)
  • HeterogeneousTest/ROCmDevice (heterogeneous)
  • HeterogeneousTest/ROCmKernel (heterogeneous)
  • HeterogeneousTest/ROCmOpaque (heterogeneous)
  • HeterogeneousTest/ROCmWrapper (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 5, 2024

In the original version we had:

Fail 17s ... HeterogeneousTest/AlpakaOpaque/testAlpakaTestOpaqueAdditionModule

This fails only in the CUDA case, due to a problem with the device-side linker and shared libraries:

----- Begin Fatal Exception 05-Apr-2024 18:07:55 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'path'
   [2] Calling method for module AlpakaTestKernelAdditionModule@alpaka/'alpakaTestKernelAdditionModule'
Exception Message:
A std::exception was thrown.
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02831/el8_amd64_gcc12/external/alpaka/1.1.0-0e409eb77df69f74c5fa8d12f3a1b08b/include/alpaka/mem/buf/uniformCudaHip/Copy.hpp(143) 'TApi::setDevice(m_iDstDevice)' A previous API call (not this one) set the error  : 'cudaErrorInvalidDeviceFunction': 'invalid device function'!
----- End Fatal Exception -------------------------------------------------

This happens also with the native CUDA code, and the failing part of the test is disabled in the CUDA case:

# this one fails with "cudaErrorInvalidDeviceFunction: invalid device function"
#process.cudaTestDeviceAdditionModule +

I've disabled it like for the CUDA test case.

@fwyzard fwyzard changed the title Use explicit acelerator types in alpaka device code Use explicit accelerator types in alpaka device code Apr 5, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dea65/38635/summary.html
COMMIT: 7f9bc74
CMSSW: CMSSW_14_1_X_2024-04-05-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44636/38635/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dea65/38635/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dea65/38635/git-merge-result

Build

I found compilation error when building:

Entering library rule at src/HeterogeneousTest/AlpakaDevice/plugins
>> Compiling alpaka/cuda src/HeterogeneousTest/AlpakaDevice/plugins/alpaka/AlpakaTestDeviceAdditionAlgo.dev.cc
>> Compiling alpaka/cuda edm plugin src/HeterogeneousTest/AlpakaDevice/plugins/alpaka/AlpakaTestDeviceAdditionModule.cc
>> Cuda Device Link tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/HeterogeneousTestAlpakaDevicePluginsCudaAsync_cudadlink.o 
nvlink error   : Undefined reference to '_ZN17alpaka_cuda_async4test13add_vectors_fERKN6alpaka22AccGpuUniformCudaHipRtINS1_9ApiCudaRtESt17integral_constantImLm1EEjEEPKfSA_Pfj' in 'tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/alpaka/AlpakaTestDeviceAdditionAlgo.dev.cc.o' (target: sm_60)
gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/HeterogeneousTestAlpakaDevicePluginsCudaAsync_cudadlink.o] Error 255
>> Building alpaka/cuda edm plugin tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/libHeterogeneousTestAlpakaDevicePluginsCudaAsync.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/HeterogeneousTestAlpakaDevicePluginsCudaAsync_cudadlink.o: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/libHeterogeneousTestAlpakaDevicePluginsCudaAsync.so] Error 1
Leaving library rule at src/HeterogeneousTest/AlpakaDevice/plugins


@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44636/39827

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

Pull request #44636 was updated. @makortel, @fwyzard, @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

Pull request #44636 was updated. @makortel, @fwyzard, @cmsbuild can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 5, 2024

please test with cms-sw/cmsdist#9121

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dea65/38642/summary.html
COMMIT: 33c945a
CMSSW: CMSSW_14_1_X_2024-04-05-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44636/38642/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dea65/38642/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dea65/38642/git-merge-result

Build

I found compilation error when building:

Entering library rule at src/HeterogeneousTest/AlpakaDevice/plugins
>> Compiling alpaka/cuda src/HeterogeneousTest/AlpakaDevice/plugins/alpaka/AlpakaTestDeviceAdditionAlgo.dev.cc
>> Compiling alpaka/cuda edm plugin src/HeterogeneousTest/AlpakaDevice/plugins/alpaka/AlpakaTestDeviceAdditionModule.cc
>> Cuda Device Link tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/HeterogeneousTestAlpakaDevicePluginsCudaAsync_cudadlink.o 
nvlink error   : Undefined reference to '_ZN17alpaka_cuda_async4test13add_vectors_fERKN6alpaka22AccGpuUniformCudaHipRtINS1_9ApiCudaRtESt17integral_constantImLm1EEjEEPKfSA_Pfj' in 'tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/alpaka/AlpakaTestDeviceAdditionAlgo.dev.cc.o' (target: sm_60)
gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/HeterogeneousTestAlpakaDevicePluginsCudaAsync_cudadlink.o] Error 255
>> Building alpaka/cuda edm plugin tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/libHeterogeneousTestAlpakaDevicePluginsCudaAsync.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/HeterogeneousTestAlpakaDevicePluginsCudaAsync_cudadlink.o: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/libHeterogeneousTestAlpakaDevicePluginsCudaAsync.so] Error 1
Leaving library rule at src/HeterogeneousTest/AlpakaDevice/plugins


@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 5, 2024

please test with cms-sw/cmsdist#9121, #44640

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dea65/38645/summary.html
COMMIT: 33c945a
CMSSW: CMSSW_14_1_X_2024-04-05-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44636/38645/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Entering library rule at src/HeterogeneousTest/AlpakaKernel/plugins
>> Compiling alpaka/cuda src/HeterogeneousTest/AlpakaKernel/plugins/alpaka/AlpakaTestKernelAdditionAlgo.dev.cc
>> Compiling alpaka/cuda edm plugin src/HeterogeneousTest/AlpakaKernel/plugins/alpaka/AlpakaTestKernelAdditionModule.cc
>> Cuda Device Link tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaKernel/plugins/HeterogeneousTestAlpakaKernelPluginsCudaAsync/HeterogeneousTestAlpakaKernelPluginsCudaAsync_cudadlink.o 
nvlink error   : Undefined reference to '_ZNK17alpaka_cuda_async4test17KernelAddVectorsFclERKN6alpaka22AccGpuUniformCudaHipRtINS2_9ApiCudaRtESt17integral_constantImLm1EEjEEPKfSB_Pfj' in 'tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaKernel/plugins/HeterogeneousTestAlpakaKernelPluginsCudaAsync/alpaka/AlpakaTestKernelAdditionAlgo.dev.cc.o' (target: sm_60)
gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaKernel/plugins/HeterogeneousTestAlpakaKernelPluginsCudaAsync/HeterogeneousTestAlpakaKernelPluginsCudaAsync_cudadlink.o] Error 255
>> Building alpaka/cuda edm plugin tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaKernel/plugins/HeterogeneousTestAlpakaKernelPluginsCudaAsync/libHeterogeneousTestAlpakaKernelPluginsCudaAsync.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaKernel/plugins/HeterogeneousTestAlpakaKernelPluginsCudaAsync/HeterogeneousTestAlpakaKernelPluginsCudaAsync_cudadlink.o: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaKernel/plugins/HeterogeneousTestAlpakaKernelPluginsCudaAsync/libHeterogeneousTestAlpakaKernelPluginsCudaAsync.so] Error 1
Leaving library rule at src/HeterogeneousTest/AlpakaKernel/plugins


@fwyzard fwyzard changed the base branch from master to CMSSW_14_1_X April 8, 2024 13:01
@fwyzard fwyzard changed the base branch from CMSSW_14_1_X to master April 8, 2024 13:02
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 9, 2024

let's retry the test now that the dependencies have been merged

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 9, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 9, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dea65/38711/summary.html
COMMIT: 33c945a
CMSSW: CMSSW_14_1_X_2024-04-09-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44636/38711/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Entering library rule at src/HeterogeneousTest/AlpakaDevice/plugins
>> Compiling alpaka/cuda src/HeterogeneousTest/AlpakaDevice/plugins/alpaka/AlpakaTestDeviceAdditionAlgo.dev.cc
>> Compiling alpaka/cuda edm plugin src/HeterogeneousTest/AlpakaDevice/plugins/alpaka/AlpakaTestDeviceAdditionModule.cc
>> Cuda Device Link tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/HeterogeneousTestAlpakaDevicePluginsCudaAsync_cudadlink.o 
nvlink error   : Undefined reference to '_ZN17alpaka_cuda_async4test13add_vectors_fERKN6alpaka22AccGpuUniformCudaHipRtINS1_9ApiCudaRtESt17integral_constantImLm1EEjEEPKfSA_Pfj' in 'tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/alpaka/AlpakaTestDeviceAdditionAlgo.dev.cc.o' (target: sm_60)
gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/HeterogeneousTestAlpakaDevicePluginsCudaAsync_cudadlink.o] Error 255
>> Building alpaka/cuda edm plugin tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/libHeterogeneousTestAlpakaDevicePluginsCudaAsync.so
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02832/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/HeterogeneousTestAlpakaDevicePluginsCudaAsync_cudadlink.o: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaDevice/plugins/HeterogeneousTestAlpakaDevicePluginsCudaAsync/libHeterogeneousTestAlpakaDevicePluginsCudaAsync.so] Error 1
Leaving library rule at src/HeterogeneousTest/AlpakaDevice/plugins


@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 9, 2024

Mhm, for me this builds and runs locally on top of the latest IB.

Is there a way to reset the PR test parameters ?

@fwyzard fwyzard closed this Apr 9, 2024
@makortel
Copy link
Contributor

makortel commented Apr 9, 2024

Is there a way to reset the PR test parameters ?

IIRC message with empty test parameters along

test parameters:

should do it

@iarspider
Copy link
Contributor

Is there a way to reset the PR test parameters ?

Remove "test parameters" comment (bot doesn't actively save parameters between invocations)

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 5, 2024

FYI, now that the new release cycle is open, this PR has been updated for CMSSW 14.2.x in #45887.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants