If TClass::GetClass() fails in TypeWithDict::byName(), include the argument class name in the exception message
#44564
Conversation
makortel
changed the title
TClass::GetClass() fails in TypeWithDict::byName(), include the argument class name in the exception message
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44564/39714
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
…xception message This should help in figuring out what class did not have a ROOT dictionary defined.
makortel
force-pushed
the
dictionaryException
branch
from
c247d6f
to
ec49f99
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44564/39715
|
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@makortel, @smuzaffar, @Dr15Jones, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
@Dr15Jones Could you review? |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f9657/38474/summary.html Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
I investigated a user problem where ROOT header auto-parsing failed because of it trying to write the
cuda.pcmto CVMFS. Printing out thenamehelped to point the actual problem (*). I thought adding thenameto the exception message would help such investigations next time.(*) the code used
edm::EDGetTokenTinstead ofdevice::EDGetTokenin an Alpaka module, that then lead to our check of "all consumed data types must have a dictionary" to make ROOT to auto-parse the headers, because the consumed (but incorrect!) type indeed did not have a dictionaryPR validation:
Checked the exception message in the example job. The added information would have immediately pointed towards the culprit.