-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TensorFlowAOT unit tests, remove dev workflow. #44519
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44519/39645
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44519/39646
|
A new Pull Request was created by @riga for master. It involves the following packages:
@wpmccormack, @cmsbuild, @valsdav can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44519/39693
|
Pull request #44519 was updated. @wpmccormack, @valsdav, @cmsbuild can you please check and sign again. |
REMINDER @antoniovilela, @sextonkennedy, @rappoccio: This PR was tested with cms-sw/cmsdist#9093, please check if they should be merged together |
please test with cms-sw/cmsdist#9093 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94885c/38486/summary.html Comparison SummarySummary:
|
@cms-sw/ml-l2 , can you please review this? This needs to go in along with cms-sw/cmsdist#9093 |
REMINDER @rappoccio, @antoniovilela, @sextonkennedy: This PR was tested with cms-sw/cmsdist#9093, please check if they should be merged together |
+ml Thanks a lot @riga @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description
This PR is a continuation of #43941 and should be tested with cms-sw/cmsdist#9093.
The development workflow for AOT compiling TensorFlow models was added to the PhysicsTools/TensorFlowAOT package in the above mentioned PR. However, with the new changes to the build process and deployment via cmsdist, these files can be removed again (as done in this PR). Instructions on how to locally AOT compile and use models for development purposes will be published on pages of the ML group soon.
PR validation
Since the pre-compiled test models are now provided as external tools, this PR enables the unit tests of the AOT interface that were already reviewed. They perform tests of a simple f32 -> f32 model, as well as a multi-input/output model with a f32,f64 -> f32,bool signature.
@Bogdan-Wiederspan @valsdav