-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computation of Isolation for GenParticles collection #44461
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44461/39544
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44461/39545
|
A new Pull Request was created by @bonanomi for master. It involves the following packages:
@hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44461/39563
|
enable nano |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e25483/38280/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44461/39812 ERROR: Unable to merge PR. See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44461/39812/cms-checkout-topic.log |
PR description:
iso
to theGenParticles
collection.GenParticles.iso
is done in theGenPartIsoProducer.cc
plugin.miniAOD
before). This issue has been discussed here and here.PR validation:
GenDressedLeptons
is out of question because that collection would require too many modifications, with unknown impact on the users.v12
andv13
nanoAOD
). A more detailed comparison is done usingGluGluHtoGG_M-125_TuneCP5_13p6TeV_amcatnloFXFX-pythia8/Run3Summer22EEMiniAODv4-130X_mcRun3_2022_realistic_postEE_v6-v2/MINIAODSIM
and the dump of the collections in the currentnanoAOD
can be found here to be compared with the one obtained with this code, that can be found here.