Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computation of Isolation for GenParticles collection #44461

Closed
wants to merge 0 commits into from
Closed

Computation of Isolation for GenParticles collection #44461

wants to merge 0 commits into from

Conversation

bonanomi
Copy link
Contributor

PR description:

  • Addition of one branch, called iso to the GenParticles collection.
  • The computation of the GenParticles.iso is done in the GenPartIsoProducer.cc plugin.
  • This PR is intended to solve the issues that different Higgs analyses (but probably the issue is wider) are facing when doing fiducial cross section measurement (done in miniAOD before). This issue has been discussed here and here.

PR validation:

  • The usage of the available GenDressedLeptons is out of question because that collection would require too many modifications, with unknown impact on the users.
  • The approach proposed here can be used by all analyses and it is not analysis/PAG specific.
  • All the other collections are not modified (tested vs v12 and v13 nanoAOD). A more detailed comparison is done using GluGluHtoGG_M-125_TuneCP5_13p6TeV_amcatnloFXFX-pythia8/Run3Summer22EEMiniAODv4-130X_mcRun3_2022_realistic_postEE_v6-v2/MINIAODSIM and the dump of the collections in the current nanoAOD can be found here to be compared with the one obtained with this code, that can be found here.

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Mar 19, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44461/39544

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44461/39545

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bonanomi for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44461/39563

@cmsbuild
Copy link
Contributor

Pull request #44461 was updated. @cmsbuild, @hqucms, @vlimant can you please check and sign again.

@cmsbuild cmsbuild mentioned this pull request Mar 20, 2024
Merged
@vlimant
Copy link
Contributor

vlimant commented Mar 20, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Mar 20, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e25483/38280/summary.html
COMMIT: c3213c0
CMSSW: CMSSW_14_1_X_2024-03-19-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44461/38280/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297369
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297346
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.84 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.115 KiB Physics/NanoAODDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.61 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.115 KiB Physics/NanoAODDQM
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.661 2.548 0.112 ( +4.4% ) 5.16 5.10 +1.2% 2.234 2.232
2500.001 2.773 2.698 0.075 ( +2.8% ) 4.59 4.61 -0.5% 2.659 2.654
2500.002 2.719 2.638 0.081 ( +3.1% ) 4.76 4.81 -1.1% 2.645 2.667
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.70 9.23 +5.2% 2.299 2.306
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.26 5.17 +1.7% 2.452 2.542
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.47 7.35 +1.7% 2.356 2.377
2500.1 2.270 2.192 0.078 ( +3.6% ) 5.17 5.12 +1.0% 2.064 2.063
2500.2 2.387 2.308 0.080 ( +3.5% ) 5.86 5.82 +0.7% 1.972 1.971
2500.21 1.181 1.181 0.000 ( +0.0% ) 4.32 4.22 +2.4% 2.264 2.265
2500.211 1.545 1.545 0.000 ( +0.0% ) 3.77 3.55 +6.4% 2.359 2.347
2500.3 2.129 2.058 0.071 ( +3.5% ) 11.78 11.41 +3.3% 1.961 1.962
2500.301 2.707 2.631 0.076 ( +2.9% ) 9.42 9.41 +0.1% 1.944 1.940
2500.31 1.254 1.254 0.000 ( +0.0% ) 19.96 18.53 +7.7% 2.345 2.337
2500.311 1.640 1.640 0.000 ( +0.0% ) 13.81 12.84 +7.5% 2.441 2.434
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.44 1.36 +5.7% 1.703 1.705
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.76 7.15 -5.4% 1.057 1.053
2500.314 1.163 1.163 0.000 ( +0.0% ) 14.28 13.53 +5.6% 2.066 2.121
2500.315 1.758 1.758 0.000 ( +0.0% ) 14.25 13.13 +8.5% 2.323 2.314
2500.316 3.091 3.091 0.000 ( +0.0% ) 2.27 2.09 +8.4% 2.268 2.278
2500.317 1.787 1.787 0.000 ( +0.0% ) 13.88 12.66 +9.6% 2.174 2.159
2500.4 2.129 2.058 0.071 ( +3.5% ) 11.72 11.68 +0.4% 1.854 1.877
2500.401 1.900 1.824 0.076 ( +4.2% ) 10.14 9.70 +4.5% 1.759 1.695
2500.402 2.707 2.631 0.076 ( +2.9% ) 9.79 9.40 +4.1% 1.952 1.947
2500.403 5.264 5.188 0.076 ( +1.5% ) 1.57 1.52 +2.9% 1.981 1.984
2500.404 2.696 2.620 0.076 ( +2.9% ) 9.53 9.06 +5.2% 1.772 1.758
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.32 1.12 +17.7% 1.364 1.361

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44461/39812

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44461/39812/cms-checkout-topic.log

@bonanomi bonanomi closed this Apr 4, 2024
@bonanomi bonanomi mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlimant vlimant vlimant left review comments

@hqucms hqucms hqucms left review comments

Assignees
No one assigned
Labels
alca-pending analysis-pending code-checks-rejected core-pending daq-pending db-pending dqm-pending generators-pending geometry-pending hcal heterogeneous-pending hlt-pending l1-pending ml-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-pending simulation-pending tests-pending tracking trk upgrade-pending visualization-pending xpog-pending
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
5 participants
@bonanomi @cmsbuild @vlimant @hqucms @antoniovilela