-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize statsGuard_ on LogErrorEventFilter #44447
Conversation
Hopefully this fixes the segfaults seeing in this module in IBs.
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44447/39517
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@sunilUIET, @miquork, @AdrianoDee, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbc8d8/38210/summary.html Comparison SummarySummary:
|
@cms-sw/pdmv-l2 Could you review and sign? |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
I found
statsGuard_
being uninitialized while running valgrind a workflow mentioned in #44413. This fix might address those failures.PR validation:
Valgrind warning is gone.