custom nano configuration and test [Backport] #44428

vlimant · 2024-03-15T15:44:48Z

PR description:

backporting #44263 #44425 #44399 #44087 to 14.0.X, mostly for Tier0 purpose

PR validation:

nano matrix

cmsbuild · 2024-03-15T15:45:13Z

A new Pull Request was created by @vlimant for CMSSW_14_0_X.

It involves the following packages:

Configuration/Applications (operations)
Configuration/PyReleaseValidation (upgrade, pdmv)
PhysicsTools/NanoAOD (xpog)

@fabiocos, @antoniovilela, @srimanob, @davidlange6, @vlimant, @subirsarkar, @sunilUIET, @AdrianoDee, @miquork, @rappoccio, @cmsbuild, @hqucms can you please review it and eventually sign? Thanks.
@fabiocos, @AnnikaStein, @Martin-Grunewald, @makortel, @gpetruc, @slomeo, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-03-15T15:45:13Z

cms-bot internal usage

vlimant · 2024-03-15T15:45:42Z

enable nano

vlimant · 2024-03-15T18:52:15Z

please test

cmsbuild · 2024-03-15T21:46:52Z

-1

Failed Tests: RelVals-INPUT RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00c89b/38179/summary.html
COMMIT: c2d3f8a
CMSSW: CMSSW_14_0_X_2024-03-15-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44428/38179/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

2500.4012500.401_muPOGNANOmc132X/step2_muPOGNANOmc132X.log

RelVals-NANO

2500.4012500.401_muPOGNANOmc132X/step2_muPOGNANOmc132X.log

Comparison Summary

The workflows 2500.4 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

You potentially removed 1168 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1653 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3346226
DQMHistoTests: Total failures: 1722
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3344482
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-03-15T23:21:24Z

Pull request #44428 was updated. @davidlange6, @cmsbuild, @vlimant, @AdrianoDee, @srimanob, @sunilUIET, @hqucms, @antoniovilela, @fabiocos, @subirsarkar, @rappoccio, @miquork can you please check and sign again.

vlimant · 2024-03-15T23:24:24Z

we'll have to deal with #44383 and the rivetMetTable so as to enable the DQM

vlimant · 2024-03-15T23:24:31Z

please test

vlimant · 2024-03-15T23:28:20Z

@rbhattacharya04 is the change to custom_muon_cff.py acceptable ?

cmsbuild · 2024-03-16T02:30:54Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00c89b/38184/summary.html
COMMIT: dc1e8bc
CMSSW: CMSSW_14_0_X_2024-03-15-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44428/38184/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 2500.4 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

You potentially removed 1071 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1631 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3346226
DQMHistoTests: Total failures: 364
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3345840
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

The workflows 2500.4 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

You potentially added 18910 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1588 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16458
DQMHistoTests: Total failures: 358
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16100
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 40 log files, 20 edm output root files, 15 DQM output files

Nano size comparison Summary:

Nano ERROR: Missing ref/2500.316-size.json
Nano ERROR: Missing ref/2500.316-size.json
Nano ERROR: Missing ref/2500.317-size.json
Nano ERROR: Missing ref/2500.317-size.json
Nano ERROR: Missing ref/2500.403-size.json
Nano ERROR: Missing ref/2500.403-size.json
Nano ERROR: Missing ref/2500.404-size.json
Nano ERROR: Missing ref/2500.404-size.json
Nano ERROR: Missing ref/2500.51-size.json
Nano ERROR: Missing ref/2500.51-size.json
| Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
| --- | --- | --- | --- | --- | --- | --- | --- | --- |
| 2500.0 | 2.555 | 2.555 | 0.000 ( +0.0% ) | 5.21 | 5.20 | +0.1% | 2.206 | 2.232 |
| 2500.001 | 2.705 | 2.705 | 0.000 ( +0.0% ) | 4.70 | 4.68 | +0.5% | 2.127 | 2.619 |
| 2500.002 | 2.646 | 2.646 | 0.000 ( +0.0% ) | 4.85 | 4.85 | +0.1% | 2.220 | 2.643 |
| 2500.01 | 1.326 | 1.326 | 0.000 ( +0.0% ) | 9.44 | 9.80 | -3.7% | 1.976 | 2.297 |
| 2500.011 | 1.749 | 1.749 | 0.000 ( +0.0% ) | 5.23 | 5.27 | -0.8% | 1.981 | 2.541 |
| 2500.012 | 1.590 | 1.590 | 0.000 ( +0.0% ) | 7.38 | 7.53 | -2.0% | 2.095 | 2.357 |
| 2500.1 | 2.198 | 2.198 | 0.000 ( +0.0% ) | 5.29 | 5.29 | -0.0% | 2.053 | 2.075 |
| 2500.2 | 2.314 | 2.314 | 0.000 ( +0.0% ) | 6.00 | 6.03 | -0.4% | 1.938 | 1.982 |
| 2500.21 | 1.190 | 1.190 | 0.000 ( +0.0% ) | 4.29 | 4.30 | -0.3% | 1.958 | 2.286 |
| 2500.211 | 1.554 | 1.554 | 0.000 ( +0.0% ) | 3.77 | 3.76 | +0.5% | 2.062 | 2.360 |
| 2500.3 | 2.065 | 2.065 | 0.000 ( +0.0% ) | 12.62 | 12.65 | -0.2% | 1.973 | 1.973 |
| 2500.301 | 2.639 | 2.639 | 0.000 ( +0.0% ) | 10.23 | 10.26 | -0.3% | 1.963 | 1.957 |
| 2500.31 | 1.262 | 1.262 | 0.000 ( +0.0% ) | 19.87 | 19.98 | -0.6% | 2.350 | 2.343 |
| 2500.311 | 1.650 | 1.650 | 0.000 ( +0.0% ) | 13.50 | 13.40 | +0.8% | 2.416 | 2.426 |
| 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.46 | 1.30 | +12.1% | 1.702 | 1.698 |
| 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 7.29 | 6.33 | +15.1% | 1.058 | 1.053 |
| 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 14.09 | 13.75 | +2.5% | 2.137 | 2.088 |
| 2500.315 | 1.768 | 1.768 | 0.000 ( +0.0% ) | 13.64 | 13.82 | -1.3% | 1.925 | 2.323 |
| 2500.4 | 2.227 | 2.065 | 0.162 ( +7.8% ) | 12.01 | 12.63 | -5.0% | 1.855 | 1.902 |
| 2500.401 | 1.749 | 1.822 | -0.074 ( -4.0% ) | 10.21 | 10.45 | -2.3% | 1.713 | 1.821 |
| 2500.402 | 2.772 | 2.639 | 0.133 ( +5.0% ) | 10.12 | 9.79 | +3.3% | 1.926 | 1.818 |
| 2500.5 | 4.936 | 19.575 | -14.639 ( -74.8% ) | 16.51 | 1.20 | +1273.5% | 1.586 | 1.134 |

cmsbuild · 2024-03-19T10:21:38Z

Pull request #44428 was updated. @sunilUIET, @subirsarkar, @miquork, @davidlange6, @cmsbuild, @fabiocos, @vlimant, @hqucms, @antoniovilela, @rappoccio, @srimanob, @AdrianoDee can you please check and sign again.

vlimant · 2024-03-19T12:40:54Z

included also the fix #44464

vlimant · 2024-03-20T09:26:39Z

please test

vlimant · 2024-03-20T10:00:21Z

I might add HCAL in the mix ( #43961 )

cmsbuild · 2024-03-20T12:13:09Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00c89b/38277/summary.html
COMMIT: af72d05
CMSSW: CMSSW_14_0_X_2024-03-19-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44428/38277/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 2500.4 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

You potentially removed 992 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1652 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3346212
DQMHistoTests: Total failures: 1713
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3344477
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

The workflows 2500.4 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

You potentially added 18912 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1588 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16458
DQMHistoTests: Total failures: 358
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16100
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 40 log files, 20 edm output root files, 15 DQM output files

Nano size comparison Summary:

Nano ERROR: Missing ref/2500.316-size.json
Nano ERROR: Missing ref/2500.316-size.json
Nano ERROR: Missing ref/2500.317-size.json
Nano ERROR: Missing ref/2500.317-size.json
Nano ERROR: Missing ref/2500.403-size.json
Nano ERROR: Missing ref/2500.403-size.json
Nano ERROR: Missing ref/2500.404-size.json
Nano ERROR: Missing ref/2500.404-size.json
Nano ERROR: Missing ref/2500.51-size.json
Nano ERROR: Missing ref/2500.51-size.json
| Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
| --- | --- | --- | --- | --- | --- | --- | --- | --- |
| 2500.0 | 2.555 | 2.555 | 0.000 ( +0.0% ) | 5.24 | 5.20 | +0.8% | 2.238 | 2.223 |
| 2500.001 | 2.705 | 2.705 | 0.000 ( +0.0% ) | 4.69 | 4.69 | -0.1% | 2.645 | 2.647 |
| 2500.002 | 2.646 | 2.646 | 0.000 ( +0.0% ) | 4.86 | 4.88 | -0.3% | 2.652 | 2.650 |
| 2500.01 | 1.326 | 1.326 | 0.000 ( +0.0% ) | 9.69 | 9.72 | -0.2% | 2.347 | 2.289 |
| 2500.011 | 1.749 | 1.749 | 0.000 ( +0.0% ) | 5.23 | 5.22 | +0.2% | 2.503 | 2.466 |
| 2500.012 | 1.590 | 1.590 | 0.000 ( +0.0% ) | 7.48 | 7.44 | +0.5% | 2.422 | 2.413 |
| 2500.1 | 2.198 | 2.198 | 0.000 ( +0.0% ) | 5.26 | 5.29 | -0.6% | 2.076 | 2.066 |
| 2500.2 | 2.314 | 2.314 | 0.000 ( +0.0% ) | 5.99 | 6.07 | -1.4% | 1.982 | 1.979 |
| 2500.21 | 1.190 | 1.190 | 0.000 ( +0.0% ) | 4.24 | 4.28 | -1.0% | 2.267 | 2.274 |
| 2500.211 | 1.554 | 1.554 | 0.000 ( +0.0% ) | 3.79 | 3.76 | +0.9% | 2.348 | 2.365 |
| 2500.3 | 2.065 | 2.065 | 0.000 ( +0.0% ) | 12.56 | 12.24 | +2.7% | 1.970 | 1.972 |
| 2500.301 | 2.639 | 2.639 | 0.000 ( +0.0% ) | 10.21 | 9.92 | +3.0% | 1.956 | 1.947 |
| 2500.31 | 1.262 | 1.262 | 0.000 ( +0.0% ) | 19.96 | 20.00 | -0.2% | 2.360 | 2.367 |
| 2500.311 | 1.650 | 1.650 | 0.000 ( +0.0% ) | 13.57 | 13.63 | -0.5% | 2.422 | 2.438 |
| 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.46 | 1.43 | +1.8% | 1.691 | 1.687 |
| 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.57 | 5.90 | +11.4% | 1.047 | 1.046 |
| 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 14.02 | 14.18 | -1.2% | 2.178 | 2.089 |
| 2500.315 | 1.768 | 1.768 | 0.000 ( +0.0% ) | 14.12 | 13.90 | +1.6% | 2.335 | 2.331 |
| 2500.4 | 2.227 | 2.065 | 0.162 ( +7.8% ) | 12.23 | 12.43 | -1.6% | 1.858 | 1.873 |
| 2500.401 | 1.749 | 1.822 | -0.074 ( -4.0% ) | 10.32 | 10.71 | -3.6% | 1.813 | 1.823 |
| 2500.402 | 2.772 | 2.639 | 0.133 ( +5.0% ) | 10.12 | 9.91 | +2.1% | 1.802 | 1.913 |
| 2500.5 | 4.936 | 19.575 | -14.639 ( -74.8% ) | 16.41 | 1.17 | +1298.1% | 1.591 | 1.176 |

vlimant · 2024-03-22T12:57:16Z

+1
no need for hcal syntax here for now

AdrianoDee · 2024-03-28T22:25:06Z

+pdmv

srimanob · 2024-03-29T14:33:17Z

+Upgrade

vlimant · 2024-03-30T09:20:16Z

@cms-sw/orp-l2 : as this PR does not change content, but only how we get to configure flavors of NANO, for the purpose of harmonized production configuration, can you please merge this in ?

antoniovilela · 2024-04-02T21:56:16Z

+1

cmsbuild · 2024-04-02T21:56:42Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

vlimant added 2 commits March 15, 2024 16:35

backport of cms-sw#44425 cms-sw#44399 cms-sw#44087

529cc08

complete backport of cms-sw#44263

c2d3f8a

cmsbuild added this to the CMSSW_14_0_X milestone Mar 15, 2024

cmsbuild added operations-pending pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending xpog-pending labels Mar 15, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 15, 2024

cmsbuild added tests-rejected and removed tests-started labels Mar 15, 2024

knock-on from cms-sw#44038

dc1e8bc

cmsbuild added tests-pending and removed tests-rejected labels Mar 15, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 15, 2024

cmsbuild removed the tests-started label Mar 16, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 20, 2024

vlimant mentioned this pull request Mar 20, 2024

Hcalnano autonano #44492

Merged

cmsbuild added tests-approved and removed tests-started labels Mar 20, 2024

cmsbuild added xpog-approved and removed xpog-pending labels Mar 22, 2024

cmsbuild added pdmv-approved and removed pdmv-pending labels Mar 28, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Mar 29, 2024

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Apr 2, 2024

cmsbuild merged commit 5eabc15 into cms-sw:CMSSW_14_0_X Apr 2, 2024
12 checks passed

vlimant deleted the custom_autonano branch April 7, 2024 13:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

custom nano configuration and test [Backport] #44428

custom nano configuration and test [Backport] #44428

vlimant commented Mar 15, 2024

cmsbuild commented Mar 15, 2024

cmsbuild commented Mar 15, 2024 •

edited

Loading

vlimant commented Mar 15, 2024

vlimant commented Mar 15, 2024

cmsbuild commented Mar 15, 2024

cmsbuild commented Mar 15, 2024

vlimant commented Mar 15, 2024

vlimant commented Mar 15, 2024

vlimant commented Mar 15, 2024

cmsbuild commented Mar 16, 2024

cmsbuild commented Mar 19, 2024

vlimant commented Mar 19, 2024

vlimant commented Mar 20, 2024

vlimant commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

vlimant commented Mar 22, 2024

AdrianoDee commented Mar 28, 2024

srimanob commented Mar 29, 2024

vlimant commented Mar 30, 2024

antoniovilela commented Apr 2, 2024

cmsbuild commented Apr 2, 2024

custom nano configuration and test [Backport] #44428

custom nano configuration and test [Backport] #44428

Conversation

vlimant commented Mar 15, 2024

PR description:

PR validation:

cmsbuild commented Mar 15, 2024

cmsbuild commented Mar 15, 2024 • edited Loading

vlimant commented Mar 15, 2024

vlimant commented Mar 15, 2024

cmsbuild commented Mar 15, 2024

RelVals-INPUT

RelVals-NANO

Comparison Summary

cmsbuild commented Mar 15, 2024

vlimant commented Mar 15, 2024

vlimant commented Mar 15, 2024

vlimant commented Mar 15, 2024

cmsbuild commented Mar 16, 2024

Comparison Summary

NANO Comparison Summary

cmsbuild commented Mar 19, 2024

vlimant commented Mar 19, 2024

vlimant commented Mar 20, 2024

vlimant commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

Comparison Summary

NANO Comparison Summary

vlimant commented Mar 22, 2024

AdrianoDee commented Mar 28, 2024

srimanob commented Mar 29, 2024

vlimant commented Mar 30, 2024

antoniovilela commented Apr 2, 2024

cmsbuild commented Apr 2, 2024

cmsbuild commented Mar 15, 2024 •

edited

Loading