Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain compatibility with RooFit prior to ROOT 6.28 #44317

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Retain compatibility with RooFit prior to ROOT 6.28 #44317

merged 1 commit into from
Mar 6, 2024

Conversation

guitargeek
Copy link
Contributor

Follows up on d52fed9.

See also this commit in ROOT:
root-project/root@0f9b90a

Closes #44312.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44317/39337

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

A new Pull Request was created by @guitargeek for master.

It involves the following packages:

  • PhysicsTools/TagAndProbe (analysis)

@cmsbuild, @tvami can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Mar 5, 2024

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Mar 5, 2024

@cmsbuild , please test for CMSSW_14_1_ROOT626_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159c2c/37910/summary.html
COMMIT: 369d0c4
CMSSW: CMSSW_14_1_ROOT626_X_2024-03-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44317/37910/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159c2c/37910/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159c2c/37910/git-merge-result

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159c2c/37909/summary.html
COMMIT: 369d0c4
CMSSW: CMSSW_14_1_X_2024-03-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44317/37909/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159c2c/37909/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159c2c/37909/git-merge-result

Comparison Summary

Summary:

  • You potentially added 85 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3342509
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342481
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 6, 2024

+1

  • tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a6288ad into cms-sw:master Mar 6, 2024
17 checks passed
@guitargeek guitargeek deleted the roofit branch March 6, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ROOT626_X] Compilation failure in PhysicsTools/TagAndProbe
4 participants