Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard open file message; minor updates #44310

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

namapane
Copy link
Contributor

@namapane namapane commented Mar 5, 2024

PR description:

Adding the standard open file message as requested in #44293.

This PR also incudes 2 minor updates:

  • add support for short int branches
  • close optional histogram files in the proper place

PR validation:

Mods checked with runtests and local tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44310/39328

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

A new Pull Request was created by @namapane for master.

It involves the following packages:

  • PhysicsTools/NanoAODTools (xpog)

@hqucms, @cmsbuild, @vlimant can you please review it and eventually sign? Thanks.
@clelange, @lenzip, @AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Mar 5, 2024

please test

@namapane
Copy link
Contributor Author

namapane commented Mar 5, 2024

please test

it will fail until somebody puts back in place the test file that was moved away by the archive scripts, cf #44293.

@iarspider
Copy link
Contributor

I have moved the file back and restarted the tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c084f/37904/summary.html
COMMIT: 354f217
CMSSW: CMSSW_14_1_X_2024-03-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44310/37904/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3339090
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3339065
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@hqucms
Copy link
Contributor

hqucms commented Mar 6, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants