Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ntuplization code for sagitta-bias studies to Alignment/OfflineValidation #44282

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 1, 2024

PR description:

The goal of this PR is to add to the Alignment/OfflineValidation package a simple ntuplization code to do "sagitta bias" weak mode studies at CMS using di-muon resonant decays data as the ones in this set of slides.
The tool is not interlaced yet in the all-in-one meta-data tool, but might be included at a later time.
I have added the new analyzer to the standard battery of unit tests.

PR validation:

Run extensive private tests, also run successfully:

  • scram b runtests_Miscellanea
  • scram b runtests_testTrackAnalysis

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to CMSSW_14_0_X for 2024 data-taking operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44282/39303

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@saumyaphor4252, @consuegs, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks.
@rsreds, @yuanchao, @tlampen, @tocheng, @adewit, @mmusich this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 4, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-518944/37871/summary.html
COMMIT: 6fdc048
CMSSW: CMSSW_14_1_X_2024-03-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44282/37871/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 20 lines to the logs
  • Reco comparison results: 53 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3338784
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338756
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44282/39316

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

Pull request #44282 was updated. @perrotta, @saumyaphor4252, @consuegs, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 4, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-518944/37877/summary.html
COMMIT: 34dbd06
CMSSW: CMSSW_14_1_X_2024-03-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44282/37877/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Mar 4, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 66fb2c8 into cms-sw:master Mar 5, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_SagittaBiasNtupler_14_1_X branch March 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants