Validation/RecoEgamma PHASE2 histos filling correction V1

[archiron]

PR description:

this PR addresses a bug in the filling of two plots containing the number of GsfElectrons and GsfElectronCores in the Phase-2 case where the barrel and endcap GsfElectrons are retrieved from two different (overlapping) collections, which requires to compute the numbers by hand.

recEleNum :

recCoreNum :

and we have verified that fot the RECO step, there is no difference :

PR validation:

scram build code-checks → OK
scram build code-format → OK

compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are OK : 49 48 47 36 22 4 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 0 failed.
here is the run-log :
runall-report-step123-.log

@beaudett

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44088/39060

• This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44088/39060/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44088/39060/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44088/39061

• This PR adds an extra 52KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44088/39061/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44088/39061/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44088/39062

• This PR adds an extra 56KB to repository

[cmsbuild]

A new Pull Request was created by @archiron for master.

It involves the following packages:

• Validation/RecoEgamma (dqm)

@syuvivida, @cmsbuild, @tjavaid, @nothingface0, @antoniovagnerini, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[tjavaid]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d5fe2/37739/summary.html
COMMIT: 9ce8030
CMSSW: CMSSW_14_1_X_2024-02-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44088/37739/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 99 lines from the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3011576
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 24
• DQMHistoTests: Total successes: 3011520
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1