-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation/RecoEgamma PHASE2 histos filling correction V1 #44088
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44088/39060
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
1ccb8ac
to
140990d
Compare
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44088/39061
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44088/39062
|
A new Pull Request was created by @archiron for master. It involves the following packages:
@syuvivida, @cmsbuild, @tjavaid, @nothingface0, @antoniovagnerini, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d5fe2/37739/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
this PR addresses a bug in the filling of two plots containing the number of GsfElectrons and GsfElectronCores in the Phase-2 case where the barrel and endcap GsfElectrons are retrieved from two different (overlapping) collections, which requires to compute the numbers by hand.
recEleNum :
recCoreNum :
and we have verified that fot the RECO step, there is no difference :
PR validation:
scram build code-checks → OK
scram build code-format → OK
compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are OK : 49 48 47 36 22 4 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 0 failed.
here is the run-log :
runall-report-step123-.log
@beaudett