Tau DQM miniAOD validation for DATA #44029

gsaha009 · 2024-02-20T14:44:33Z

PR description:

Following the last PR #41995, the miniAOD validation on DATA is prepared for Run3. Twiki page: https://twiki.cern.ch/twiki/bin/viewauth/CMS/SWGuidePFTauIDValidation

PR validation:

PR runs fine in local pipeline, and even with workflows.
The main validation sequence is divided into two: for MC and Data. The MC sequence is plugged in the validation and the DATA is in the DQM.
Tests done with workflow: runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NA

Thanks @sroychow

cmsbuild · 2024-02-20T14:45:01Z

cms-bot internal usage

cmsbuild · 2024-02-20T14:51:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44029/38962

This PR adds an extra 40KB to repository

cmsbuild · 2024-02-20T14:52:06Z

A new Pull Request was created by @gsaha009 for master.

It involves the following packages:

Validation/RecoTau (dqm)

@tjavaid, @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

tjavaid · 2024-02-20T15:54:37Z

please test

cmsbuild · 2024-02-20T17:26:02Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a77f16/37584/summary.html
COMMIT: 1f73cfc
CMSSW: CMSSW_14_1_X_2024-02-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44029/37584/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

135.4

----- Begin Fatal Exception 20-Feb-2024 17:21:07 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module TauValPatJetSelector/'kinematicSelectedPFJets'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::Jet>
Looking for module label: slimmedJets
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

5.1

----- Begin Fatal Exception 20-Feb-2024 17:21:09 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module TauValPatJetSelector/'kinematicSelectedPFJets'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::Jet>
Looking for module label: slimmedJets
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

tjavaid · 2024-05-16T02:51:35Z

please test

cmsbuild · 2024-05-16T04:41:40Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a77f16/39396/summary.html
COMMIT: 1f73cfc
CMSSW: CMSSW_14_1_X_2024-05-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44029/39396/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

135.4

----- Begin Fatal Exception 16-May-2024 05:22:00 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module TauValPatJetSelector/'kinematicSelectedPFJets'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::Jet>
Looking for module label: slimmedJets
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

5.1

----- Begin Fatal Exception 16-May-2024 05:22:03 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module TauValPatJetSelector/'kinematicSelectedPFJets'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::Jet>
Looking for module label: slimmedJets
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

cmsbuild · 2024-06-23T14:39:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44029/40680

This PR adds an extra 24KB to repository

cmsbuild · 2024-06-23T14:39:32Z

Pull request #44029 was updated. @antoniovilela, @rvenditti, @davidlange6, @antoniovagnerini, @syuvivida, @tjavaid, @rappoccio, @cmsbuild, @fabiocos, @nothingface0 can you please check and sign again.

sroychow · 2024-06-23T18:40:24Z

please test

cmsbuild · 2024-06-23T21:51:07Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a77f16/40024/summary.html
COMMIT: 9e45bf6
CMSSW: CMSSW_14_1_X_2024-06-23-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44029/40024/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOfflineConfigurationGotAll had ERRORS

Comparison Summary

Summary:

You potentially added 270 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3343324
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 911
DQMHistoTests: Total successes: 3342387
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 113342.45 KiB( 47 files compared)
DQMHistoSizes: changed ( 10224.0,... ): 3356.640 KiB RecoTauV/miniAODValidation
DQMHistoSizes: changed ( 10224.0,... ): -0.113 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 10224.0,... ): -0.113 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 13234.0,... ): 3575.469 KiB RecoTauV/miniAODValidation
DQMHistoSizes: changed ( 136.7611,... ): 2921.013 KiB RecoTauV/miniAODValidation
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 21 / 46 workflows

gsaha009 · 2024-06-24T14:09:00Z

Hi @danielwinterbottom
Can you please have a look? Thanks

gsaha009 · 2024-06-24T16:44:01Z

Update: This workflow 25202.0 failed for other CMSSW versions as well, even without the changes for TauDQM made in this PR @cmsbuild
The error in wf 25202.0 only is the following:

DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval2016,ENDJOB
We have determined that this is simulation (if not, rerun cmsDriver.py with --data)
entry file:step1.root
the query is file dataset = /RelValMinBias_13/CMSSW_10_6_0-106X_mcRun2_asymptotic_v3-v1/GEN-SIM
DAS succeeded after 1 attempts 0
found files:  []
Step: DIGI Spec: ['pdigi_valid']
Step: L1 Spec: 
Step: DIGI2RAW Spec: 
Step: HLT Spec: ['@relval2016']
Step: ENDJOB Spec: 
customising the process with customizeHLTforMC from HLTrigger/Configuration/customizeHLTforMC
Starting  cmsRun  step2_DIGI_L1_DIGI2RAW_HLT_PU.py
2024-06-24 17:06:32.769201: I tensorflow/core/util/port.cc:110] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.
24-Jun-2024 17:06:34 CEST  Initiating request to open file file:step1.root
24-Jun-2024 17:06:34 CEST  Successfully opened file file:step1.root
24-Jun-2024 17:06:38 CEST  Closed file file:step1.root
----- Begin Fatal Exception 24-Jun-2024 17:06:38 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

and this is not because of the changes made in this PR

gsaha009 · 2024-07-11T09:40:37Z

Hi,
@antoniovilela, @rvenditti, @davidlange6, @antoniovagnerini, @syuvivida, @tjavaid, @rappoccio, @cmsbuild, @fabiocos, @nothingface0 @danielwinterbottom @cardinia @mbluj

can anyone of you please check?
Thanks

gsaha009 · 2024-07-24T09:58:27Z

please test

cmsbuild · 2024-08-27T08:09:19Z

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

antoniovilela · 2024-09-03T09:41:31Z

ping (to make bot change milestone)

cmsbuild added this to the CMSSW_14_1_X milestone Feb 20, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 20, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 20, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 20, 2024

cmsbuild added tests-rejected and removed tests-started labels Feb 20, 2024

cmsbuild added tests-started and removed tests-rejected labels May 16, 2024

cmsbuild added tests-rejected and removed tests-started labels May 16, 2024

gsaha009 added 3 commits June 21, 2024 20:39

Tau offline validation with data

e80e906

remove cout

2ca87f8

TauValidation for Data in dqm and MC in validation

7b562f9

gsaha009 force-pushed the CMSSW_14_0_X-tau-pog_TauDQM branch from 1f73cfc to 7b562f9 Compare June 21, 2024 22:02

cmsbuild added operations-pending and removed tests-rejected code-checks-approved labels Jun 21, 2024

cmsbuild added code-checks-pending and removed code-checks-approved labels Jun 23, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 23, 2024

cmsbuild added tests-started and removed tests-pending labels Jun 23, 2024

cmsbuild added tests-rejected and removed tests-started labels Jun 23, 2024

cmsbuild mentioned this pull request Aug 16, 2024

Parametrized magnetic field in alpaka #44360

Merged

cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024

cmsbuild mentioned this pull request Aug 29, 2024

modify turnon plots of BTV DQM #45809

Merged

cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Sep 3, 2024

This was referenced Oct 2, 2024

Move "hybrid" tau production from nano to mini step #46196

Merged

Removing Muon POG DQM sequence from Express pipeline #46293

Merged

cmsbuild mentioned this pull request Oct 12, 2024

DQM: restore Muon POG sequence (and CSC Monitor), revert #46293 #46364

Merged

cmsbuild mentioned this pull request Oct 22, 2024

Removing Muon POG DQM sequence from express, with fix for CSC monitoring #46473

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tau DQM miniAOD validation for DATA #44029

Tau DQM miniAOD validation for DATA #44029

gsaha009 commented Feb 20, 2024 •

edited

Loading

cmsbuild commented Feb 20, 2024 •

edited

Loading

cmsbuild commented Feb 20, 2024

cmsbuild commented Feb 20, 2024

tjavaid commented Feb 20, 2024

cmsbuild commented Feb 20, 2024

tjavaid commented May 16, 2024

cmsbuild commented May 16, 2024

cmsbuild commented Jun 23, 2024

cmsbuild commented Jun 23, 2024

sroychow commented Jun 23, 2024

cmsbuild commented Jun 23, 2024

gsaha009 commented Jun 24, 2024 •

edited

Loading

gsaha009 commented Jun 24, 2024 •

edited

Loading

gsaha009 commented Jul 11, 2024 •

edited

Loading

gsaha009 commented Jul 24, 2024

cmsbuild commented Aug 27, 2024

antoniovilela commented Sep 3, 2024

Tau DQM miniAOD validation for DATA #44029

Are you sure you want to change the base?

Tau DQM miniAOD validation for DATA #44029

Conversation

gsaha009 commented Feb 20, 2024 • edited Loading

cmsbuild commented Feb 20, 2024 • edited Loading

cmsbuild commented Feb 20, 2024

cmsbuild commented Feb 20, 2024

tjavaid commented Feb 20, 2024

cmsbuild commented Feb 20, 2024

RelVals

tjavaid commented May 16, 2024

cmsbuild commented May 16, 2024

RelVals

cmsbuild commented Jun 23, 2024

cmsbuild commented Jun 23, 2024

sroychow commented Jun 23, 2024

cmsbuild commented Jun 23, 2024

Unit Tests

Comparison Summary

gsaha009 commented Jun 24, 2024 • edited Loading

gsaha009 commented Jun 24, 2024 • edited Loading

gsaha009 commented Jul 11, 2024 • edited Loading

gsaha009 commented Jul 24, 2024

cmsbuild commented Aug 27, 2024

antoniovilela commented Sep 3, 2024

gsaha009 commented Feb 20, 2024 •

edited

Loading

cmsbuild commented Feb 20, 2024 •

edited

Loading

gsaha009 commented Jun 24, 2024 •

edited

Loading

gsaha009 commented Jun 24, 2024 •

edited

Loading

gsaha009 commented Jul 11, 2024 •

edited

Loading