Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triplet emulator 14 0 0 pre3 #43998

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

gkaratha
Copy link
Contributor

Dear all,

This PR is to merge the newly developed track triplet emulator in the l1t offline. The code and algorithm was presented in the last GTT meeting (https://indico.cern.ch/event/1356822/ 2nd entry). I have added new data formats and the core code. The code is tuned for the W->3pi decay. I have made the PR to l1t offline integration branch as well. The review happened in this PR: cms-l1t-offline#1190 . The rebased PR to l1t is here: cms-l1t-offline#1209

Best regards,
George

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43998/38918

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gkaratha for master.

It involves the following packages:

  • DataFormats/L1TCorrelator (l1, upgrade)
  • DataFormats/L1Trigger (l1)
  • L1Trigger/L1TTrackMatch (l1, upgrade)

@subirsarkar, @epalencia, @srimanob, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis, @kreczko, @eyigitba, @rovere, @dinyar, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b2d44/37533/summary.html
COMMIT: ff35286
CMSSW: CMSSW_14_1_X_2024-02-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43998/37533/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

+l1

@subirsarkar
Copy link

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

@gkaratha @cms-sw/l1-l2
It seems one could squash even all commits in this PR [1]?
Thanks.

[1]

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants