Remove or replace OwnVector<SiStripMatchedRecHit2D>

[wddgit]

PR description:

This is part of a campaign to remove code related to OwnVector. This is in preparation for a possible move to RNTuple from TTree as a persistence mechanism. RNTuple does not support OwnVector because it allows polymorphism. Issue #42734 discusses this in more detail.

In this PR, OwnVector<SiStripMatchedRecHit2D> is removed or replaced. This is one of the classes on Matti's list in the issue.

The dictionaries in classes_def.xml are removed and also an unused typedef.

The other usage in SiStripRecHitMatcher and SiStripRecHitConverterAlgorithm is replaced by a std::vector<std::unique_ptr<SiStripMatchedRecHit2D>>. As used in that part of the code, the object is not persistent so there aren't any backward compatibility issues and the replacement should work exactly the same as the OwnVector.

It appears that the OwnVector dictionaries were originally introduced in 2006 and new DetSetVector containers replaced them in 2007. Probably the OwnVector code was kept for backward compatibility originally and no one ever had time or remembered to clean it up when backward compatibility to 2007 was no longer needed.

PR validation:

This relies on existing tests for the part that was converted to a vector<unique_ptr>. It should work identically to the way it worked before.

To test the deletion of the dictionaries, I added this in OwnVector.h and built

class OwnVector {
    static_assert(!std::is_same_v<T, SiStripRecHitMatcher>,
        "foo does not support Bar1");

This demonstrates nothing could be using this or writing this type persistently. I did that for a 14_1_X IB and also for 10_6_39. I suspect nothing has written products of this type since 2007, but didn't verify that with a test. 10_6_X is what we need for the legacy release work.

FYI @makortel

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43987/38908

• This PR adds an extra 32KB to repository

[wddgit]

please test

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

• DataFormats/TrackerRecHit2D (reconstruction)
• RecoLocalTracker/SiStripRecHitConverter (reconstruction)
• SLHCUpgradeSimulations/Geometry (upgrade, geometry)

@subirsarkar, @makortel, @srimanob, @jfernan2, @Dr15Jones, @mdhildreth, @mandrenguyen, @civanch, @bsunanda can you please review it and eventually sign? Thanks.
@gbenelli, @GiacomoSguazzoni, @gpetruc, @echabert, @yduhm, @threus, @JanFSchulte, @robervalwalsh, @missirol, @felicepantaleo, @mtosi, @VinInn, @jlidrych, @alesaggio, @VourMa, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-144c09/37508/summary.html
COMMIT: 1c639d2
CMSSW: CMSSW_14_1_X_2024-02-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43987/37508/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 98 lines from the logs
• Reco comparison results: 57 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248554
• DQMHistoTests: Total failures: 1189
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247343
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[wddgit]

Note that the part of this requiring upgrade and geometry signatures only deletes some comment lines (containing the deleted typedef) and removes one unused "#include "OwnVector.h".

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1