[14_0_X] Remove unpackLayer1 option from L1REPACK:Full

[eyigitba]

PR description:

This PR removes the unpackLayer1 from L1REPACK:Full. This was brought into our attention by TSG colleagues and it was causing unrealistic rates when re-emulating data after 2023A.

There might be an underlying reason to why this problem started happening, but for the time being we prefer to remove this option and use unpackHcal directly. This is more in line with how ECAL TPs are used. The unpackLayer1 step was probably an artifact from Run 2, which is not needed anymore.

PR validation:

Validated that the L1REPACK:Full workflows still work after the change and the rates obtained are as expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #43981

FYI @missirol @savarghe @caruta @aloeliger @epalencia

[cmsbuild]

A new Pull Request was created by @eyigitba for CMSSW_14_0_X.

It involves the following packages:

• Configuration/StandardSequences (operations)

@cmsbuild, @fabiocos, @davidlange6, @rappoccio, @antoniovilela can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @dgulhan, @JanFSchulte, @makortel, @fabiocos, @Martin-Grunewald, @missirol, @slomeo, @sameasy, @mmusich, @VourMa, @GiacomoSguazzoni, @mtosi, @VinInn this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[Martin-Grunewald]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4aa312/37504/summary.html
COMMIT: b74de4a
CMSSW: CMSSW_14_0_X_2024-02-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43985/37504/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• You potentially removed 15 lines from the logs
• Reco comparison results: 37 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248626
• DQMHistoTests: Total failures: 9185
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3239419
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: found differences in 3 / 46 workflows

[Martin-Grunewald]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4aa312/37515/summary.html
COMMIT: b74de4a
CMSSW: CMSSW_14_0_X_2024-02-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43985/37515/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 57 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248626
• DQMHistoTests: Total failures: 10374
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3238230
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: found differences in 3 / 46 workflows

[eyigitba]

Hi, can @cms-sw/operations-l2 have a look at this PR and merge it as well? The main PR was merged last week. Thanks!

[antoniovilela]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.