Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement quick fix for eta going out of scope #43852

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

ccahoughton
Copy link
Contributor

PR description:

Added quick fix to eta bin indices going out of scope. cms-sw/cmssw#43723 shows that in CMSSW_14_0_0_pre2, a problem emerges when tracks with |eta| > 2.4 are put through the emulator, causing the resultant bin index to have a negative value. The quick fix is to simply discard tracks outside of the allowed eta region for the track jet emulator. There should be no change to the output jets.

PR validation:

#43723 (comment) this comment shows a specific event that causes a segfault. With the implemented changes, there is no segfault at this event.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43852/38689

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2024

A new Pull Request was created by @ccahoughton for master.

It involves the following packages:

  • L1Trigger/L1TTrackMatch (upgrade, l1)

@srimanob, @aloeliger, @cmsbuild, @subirsarkar, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e458e/37193/summary.html
COMMIT: ae02d4e
CMSSW: CMSSW_14_0_X_2024-02-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43852/37193/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@subirsarkar
Copy link

@ccahoughton Even if it is a quick fix, please use phiBins_ - 1 and etaBins_ - 1 in place of 23 and 26 respectively.

//This is a quick fix to eta going outside of scope - also including protection against phi going outside
//of scope as well. The eta index, j, cannot be less than zero or greater than 23 (the number of eta bins).
//The phi index, i, cannot be less than zero or greater than 26 (the number of phi bins).
if ((j < 0) || (j > 23) || (i < 0) || (i > 26))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You allow bin=0, is it underflow? Or this is just your definition. I see you have the config as

etaBins=cms.int32(24),
phiBins=cms.int32(27),

@srimanob
Copy link
Contributor

srimanob commented Feb 3, 2024

Testing in private production, issue is gone. I can completely produce sample with no crash (using 1000 events/lumi).

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43852/38703

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e458e/37221/summary.html
COMMIT: 9620e99
CMSSW: CMSSW_14_0_X_2024-02-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43852/37221/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248614
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248583
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@epalencia
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_14_1_X Feb 6, 2024
@srimanob
Copy link
Contributor

srimanob commented Feb 7, 2024

@ccahoughton
As master is moved to 14_1, could you please make the backport of this PR to 14_0?

@srimanob
Copy link
Contributor

srimanob commented Feb 9, 2024

Kindly ping @subirsarkar
Thx.

@subirsarkar
Copy link

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a995ab1 into cms-sw:master Feb 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants