Implement quick fix for eta going out of scope

[ccahoughton]

PR description:

Added quick fix to eta bin indices going out of scope. cms-sw/cmssw#43723 shows that in CMSSW_14_0_0_pre2, a problem emerges when tracks with |eta| > 2.4 are put through the emulator, causing the resultant bin index to have a negative value. The quick fix is to simply discard tracks outside of the allowed eta region for the track jet emulator. There should be no change to the output jets.

PR validation:

#43723 (comment) this comment shows a specific event that causes a segfault. With the implemented changes, there is no segfault at this event.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43852/38689

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @ccahoughton for master.

It involves the following packages:

• L1Trigger/L1TTrackMatch (upgrade, l1)

@srimanob, @aloeliger, @cmsbuild, @subirsarkar, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e458e/37193/summary.html
COMMIT: ae02d4e
CMSSW: CMSSW_14_0_X_2024-02-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43852/37193/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 104 lines from the logs
• Reco comparison results: 60 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248620
• DQMHistoTests: Total failures: 1189
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247409
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[subirsarkar]

@ccahoughton Even if it is a quick fix, please use phiBins_ - 1 and etaBins_ - 1 in place of 23 and 26 respectively.

[srimanob]

You allow bin=0, is it underflow? Or this is just your definition. I see you have the config as

etaBins=cms.int32(24),
phiBins=cms.int32(27),

[srimanob]

Testing in private production, issue is gone. I can completely produce sample with no crash (using 1000 events/lumi).

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43852/38703

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43852/38703/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43852/38703/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e458e/37221/summary.html
COMMIT: 9620e99
CMSSW: CMSSW_14_0_X_2024-02-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43852/37221/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248614
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3248583
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[epalencia]

+l1

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

[srimanob]

@ccahoughton
As master is moved to 14_1, could you please make the backport of this PR to 14_0?

[srimanob]

Kindly ping @subirsarkar
Thx.

[subirsarkar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1