[SIMULATION-UPGRADE] Define missing assignment operator to fix warnings reported in DEVEL IBs

[aandvalenzuela]

Hello,

This PR solves the DEVEL warnings on deprecated implicit assignment operators present in the IBs on the DataFormats modules.

Thanks,
Andrea

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43459/38012

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master.

It involves the following packages:

• DataFormats/FTLDigi (upgrade, simulation)
• DataFormats/HGCDigi (upgrade, simulation)
• DataFormats/HGCalDigi (upgrade, simulation)

@mdhildreth, @cmsbuild, @srimanob, @civanch can you please review it and eventually sign? Thanks.
@fabiocos, @bsunanda, @apsallid, @youyingli, @lgray, @cseez, @missirol, @pfs, @vandreev11, @sethzenz, @hatakeyamak, @rovere this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[aandvalenzuela]

please test for CMSSW_14_0_DEVEL_X

[aandvalenzuela]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-068801/36222/summary.html
COMMIT: 4f342c4
CMSSW: CMSSW_14_0_X_2023-11-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43459/36222/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 8 lines from the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 73
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3369937
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-068801/36221/summary.html
COMMIT: 4f342c4
CMSSW: CMSSW_14_0_DEVEL_X_2023-11-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43459/36221/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 9 lines from the logs
• Reco comparison results: 3600 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 5301
• DQMHistoTests: Total nulls: 80
• DQMHistoTests: Total successes: 3364629
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[civanch]

There are significant number of regression breaks. About 1000 connected with MkFit WF, which fails regularly, another one likely also spurious but is a new one. Should we restart the test?

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-068801/36270/summary.html
COMMIT: 4f342c4
CMSSW: CMSSW_14_0_X_2023-12-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43459/36270/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 25 lines to the logs
• Reco comparison results: 13 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 92
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3369918
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

Technical PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1