Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hcx359 Define modules for HFNose following the structure of updated HGCal (as in V17 version) #43445

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

bsunanda
Copy link
Contributor

PR description:

Define modules for HFNose following the structure of updated HGCal (as in V17 version)

PR validation:

Tested using fireworks

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43445/37992

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/ForwardCommonData (geometry)
  • Geometry/HGCalCommonData (geometry, upgrade)

@srimanob, @makortel, @bsunanda, @civanch, @mdhildreth, @Dr15Jones, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82e2d7/36201/summary.html
COMMIT: 35b66c5
CMSSW: CMSSW_14_0_X_2023-11-30-0800/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43445/36201/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 37 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3370032
  • DQMHistoTests: Total failures: 79
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3369931
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Dec 1, 2023

+1

@srimanob
Copy link
Contributor

srimanob commented Dec 1, 2023

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants