Short Matrix Update And Documentation

[AdrianoDee]

PR description:

Having checked with experts, this PR proposes to change the wfs we run in the short matrix.

Additions

• Run3 (2023) ZEE MC;
• Run2023D ZeroBias and EGamma data;
• Run2022B/C/D ZeroBias data.

Removals:

• 2021 express and prompt 2021;
• X.914 (since DB is already the default);
• X.911 (mostly for XML checks, could be run in the IB tests only).

This is just a first round of changes. Iteratively I will check if we can remove/add other wfs.

I took the chance to a table in the runTheMatrix.py README as a form of documentation of what we run. And some comments in runTheMatrix.py itself.

PR validation:

None

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43439/37975

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): Guard for No Digis for Phase2 and Patatrack NuGun #41255, [NanoAOD,BTVNano] Btvnano integration as customized module #43401

[cmsbuild]

A new Pull Request was created by @AdrianoDee (Adriano Di Florio) for master.

It involves the following packages:

• Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @sunilUIET, @srimanob, @cmsbuild, @miquork can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @slomeo, @fabiocos, @makortel, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[AdrianoDee]

please test

[makortel]

Should something from 2021 data be kept? Or is 139.001 enough? (not sure what "offline with HLT step" means exactly)

I don't see anything for 2022 data, maybe it would be worth to have one re-reco workflow for 2022 data?

Just to note that after removing 11634.911 we can pretty much close #35109 (without finding the cause, but I'm not against removing it).

[makortel]

How about moving these data workflows upwards in the list before the MC workflows? I'd find alternating data and MC workflows potentially confusing (but the maintenance of this list is not really up to me).

[AdrianoDee]

Indeed. Let me reshuffle them.

[cmsbuild]

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93f24e/36180/summary.html
COMMIT: ab911b8
CMSSW: CMSSW_14_0_X_2023-11-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43439/36180/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-runTheMatrix-interactive had ERRORS

RelVals

[AdrianoDee]

I don't see anything for 2022 data, maybe it would be worth to have one re-reco workflow for 2022 data?

Yes for 2022 would makes sense to have something. For 2021 there's not much in the release in general. The Express I removed I don't know how much is useful for PR testing. The only extra one I would consider is 139.002 that is 2021 ZeroBias.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43439/37979

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): Guard for No Digis for Phase2 and Patatrack NuGun #41255, [NanoAOD,BTVNano] Btvnano integration as customized module #43401

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43439/38204

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_2017.py modified in PR(s): Guard for No Digis for Phase2 and Patatrack NuGun #41255
  • File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): Guard for No Digis for Phase2 and Patatrack NuGun #41255

[cmsbuild]

Pull request #43439 was updated. @cmsbuild, @subirsarkar, @srimanob, @miquork, @AdrianoDee, @sunilUIET can you please check and sign again.

[AdrianoDee]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93f24e/36504/summary.html
COMMIT: 19f3de0
CMSSW: CMSSW_14_0_X_2023-12-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43439/36504/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 32 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2734226
• DQMHistoTests: Total failures: 1214
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2732990
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 175 log files, 136 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

[AdrianoDee]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1