-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Short Matrix Update And Documentation #43439
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43439/37975
|
A new Pull Request was created by @AdrianoDee (Adriano Di Florio) for master. It involves the following packages:
@AdrianoDee, @sunilUIET, @srimanob, @cmsbuild, @miquork can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Should something from 2021 data be kept? Or is 139.001 enough? (not sure what "offline with HLT step" means exactly) I don't see anything for 2022 data, maybe it would be worth to have one re-reco workflow for 2022 data? Just to note that after removing 11634.911 we can pretty much close #35109 (without finding the cause, but I'm not against removing it). |
141.044 # 2023D JetMET PD | ||
141.042 # 2023D ZeroBias PD | ||
141.046 # 2023D EGamma PD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving these data workflows upwards in the list before the MC workflows? I'd find alternating data and MC workflows potentially confusing (but the maintenance of this list is not really up to me).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Let me reshuffle them.
-1 Failed Tests: UnitTests RelVals Unit TestsI found 1 errors in the following unit tests: ---> test test-runTheMatrix-interactive had ERRORS RelVals |
Yes for 2022 would makes sense to have something. For 2021 there's not much in the release in general. The |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43439/37979
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43439/38204
|
Pull request #43439 was updated. @cmsbuild, @subirsarkar, @srimanob, @miquork, @AdrianoDee, @sunilUIET can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93f24e/36504/summary.html Comparison SummarySummary:
|
+Upgrade |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Having checked with experts, this PR proposes to change the wfs we run in the short matrix.
Additions
Removals:
This is just a first round of changes. Iteratively I will check if we can remove/add other wfs.
I took the chance to a table in the
runTheMatrix.py
README as a form of documentation of what we run. And some comments inrunTheMatrix.py
itself.PR validation:
None