Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix primary vertex source for HLT tracking monitoring for Phase-2 / HIon #43427

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 29, 2023

PR description:

In the process of the alca validation CMSALCA-240 it was noticed that the track IP wrt PV plots are empty (e.g. https://tinyurl.com/yru69pww).
This is due to a leftover customization that was forgotten at #43141.
Coincidentally I notice that also the Phase-2 customization introduced back then in #42783 was not taking the different name of the pixel PV collection.
Both are fixed here. I profit of the PR to drop the cms type specification as generally required.

PR validation:

Run successfully runTheMatrix.py -l 142.0,24834.0 -t 4 -j 8 --ibeos and checked that the empty plots are now filled.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but could be backported (at least to 13.3.X)

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43427/37956

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@syuvivida, @nothingface0, @tjavaid, @antoniovagnerini, @cmsbuild, @rvenditti can you please review it and eventually sign? Thanks.
@cericeci, @jhgoh, @rociovilar, @trocino, @HuguesBrun, @mtosi, @missirol, @Fedespring this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a20d6c/36150/summary.html
COMMIT: 77e488a
CMSSW: CMSSW_14_0_X_2023-11-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43427/36150/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2023

DQMHistoTests: Total failures: 621

as expected now phase-2 HLT monitoring plots w.r.t PV are filled: https://tinyurl.com/ysv5b3wj

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2023

@cms-sw/dqm-l2 @cms-sw/orp-l2 please consider this bug-fix for pre2

@tjavaid
Copy link

tjavaid commented Nov 30, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4aae6ff into cms-sw:master Nov 30, 2023
11 checks passed
@mmusich mmusich deleted the fixPVforHLTtrackingMonitoring branch November 30, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants