Fix deprecated-copy warnings in L1Trigger/L1CaloTrigger #43396

iarspider · 2023-11-27T10:05:53Z

PR description:

Fix deprecated-copy warnings (rule-of-three violation) in L1Trigger/L1CaloTrigger:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h: In copy constructor 'p2eg::towers3x4::towers3x4(const p2eg::towers3x4&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:484:51: warning: implicitly-declared 'p2eg::towerHCAL& p2eg::towerHCAL::operator=(const p2eg::towerHCAL&)' is deprecated [-Wdeprecated-copy]
   484 |           towersHCAL[i][j] = other.towersHCAL[i][j];
      |                                                   ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:448:5: note: because 'p2eg::towerHCAL' has user-provided 'p2eg::towerHCAL::towerHCAL(const p2eg::towerHCAL&)'
  448 |     towerHCAL(const towerHCAL& other) {
      |     ^~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h: In copy constructor 'p2eg::card::card(const p2eg::card&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:537:49: warning: implicitly-declared 'p2eg::towers3x4& p2eg::towers3x4::operator=(const p2eg::towers3x4&)' is deprecated [-Wdeprecated-copy]
   537 |         card3x4Towers[i] = other.card3x4Towers[i];
      |                                                 ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:480:5: note: because 'p2eg::towers3x4' has user-provided 'p2eg::towers3x4::towers3x4(const p2eg::towers3x4&)'
  480 |     towers3x4(const towers3x4& other) {
      |     ^~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h: In member function 'p2eg::towers3x4& p2eg::towers3x4::operator=(const p2eg::towers3x4&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:470:9: warning: implicitly-declared 'p2eg::towerHCAL& p2eg::towerHCAL::operator=(const p2eg::towerHCAL&)' is deprecated [-Wdeprecated-copy]
   470 |   class towers3x4 {
      |         ^~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:448:5: note: because 'p2eg::towerHCAL' has user-provided 'p2eg::towerHCAL::towerHCAL(const p2eg::towerHCAL&)'
  448 |     towerHCAL(const towerHCAL& other) {
      |     ^~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h: In copy constructor 'p2eg::card::card(const p2eg::card&)':
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:537:49: note: synthesized method 'p2eg::towers3x4& p2eg::towers3x4::operator=(const p2eg::towers3x4&)' first required here
  537 |         card3x4Towers[i] = other.card3x4Towers[i];
      |                                                 ^
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloEGammaEmulator.cc:55:
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h: In function 'p2eg::crystalMax p2eg::getPeakBin15N(etaStripPeak_t)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1007:10: warning: implicitly-declared 'p2eg::crystalMax::crystalMax(const p2eg::crystalMax&)' is deprecated [-Wdeprecated-copy]
  1007 |   return x;
      |          ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:610:17: note: because 'p2eg::crystalMax' has user-provided 'p2eg::crystalMax& p2eg::crystalMax::operator=(const p2eg::crystalMax&)'
  610 |     crystalMax& operator=(const crystalMax& rhs) {
      |                 ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h: In function 'p2eg::clusterInfo p2eg::getClusterPosition(ecalRegion_t)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1091:10: warning: implicitly-declared 'p2eg::clusterInfo::clusterInfo(const p2eg::clusterInfo&)' is deprecated [-Wdeprecated-copy]
  1091 |   return cluster;
      |          ^~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:786:18: note: because 'p2eg::clusterInfo' has user-provided 'p2eg::clusterInfo& p2eg::clusterInfo::operator=(const p2eg::clusterInfo&)'
  786 |     clusterInfo& operator=(const clusterInfo& rhs) {
      |                  ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h: In function 'p2eg::Cluster p2eg::packCluster(ap_uint<15>&, ap_uint<5>&, ap_uint<5>&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1112:10: warning: implicitly-declared 'p2eg::Cluster::Cluster(const p2eg::Cluster&)' is deprecated [-Wdeprecated-copy]
  1112 |   return pack;
      |          ^~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:856:14: note: because 'p2eg::Cluster' has user-provided 'p2eg::Cluster& p2eg::Cluster::operator=(const p2eg::Cluster&)'
  856 |     Cluster& operator=(const Cluster& rhs) {
      |              ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h: In function 'p2eg::clusterInfo p2eg::getBremsValuesPos(crystal (*)[20], ap_uint<5>, ap_uint<5>)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1231:10: warning: implicitly-declared 'p2eg::clusterInfo::clusterInfo(const p2eg::clusterInfo&)' is deprecated [-Wdeprecated-copy]
  1231 |   return cluster_tmp;
      |          ^~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:786:18: note: because 'p2eg::clusterInfo' has user-provided 'p2eg::clusterInfo& p2eg::clusterInfo::operator=(const p2eg::clusterInfo&)'
  786 |     clusterInfo& operator=(const clusterInfo& rhs) {
      |                  ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h: In function 'p2eg::clusterInfo p2eg::getBremsValuesNeg(crystal (*)[20], ap_uint<5>, ap_uint<5>)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1306:10: warning: implicitly-declared 'p2eg::clusterInfo::clusterInfo(const p2eg::clusterInfo&)' is deprecated [-Wdeprecated-copy]
  1306 |   return cluster_tmp;
      |          ^~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:786:18: note: because 'p2eg::clusterInfo' has user-provided 'p2eg::clusterInfo& p2eg::clusterInfo::operator=(const p2eg::clusterInfo&)'
  786 |     clusterInfo& operator=(const clusterInfo& rhs) {
      |                  ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h: In function 'p2eg::clusterInfo p2eg::getClusterValues(crystal (*)[20], ap_uint<5>, ap_uint<5>)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1410:10: warning: implicitly-declared 'p2eg::clusterInfo::clusterInfo(const p2eg::clusterInfo&)' is deprecated [-Wdeprecated-copy]
  1410 |   return cluster_tmp;
      |          ^~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:786:18: note: because 'p2eg::clusterInfo' has user-provided 'p2eg::clusterInfo& p2eg::clusterInfo::operator=(const p2eg::clusterInfo&)'
  786 |     clusterInfo& operator=(const clusterInfo& rhs) {
      |                  ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h: In function 'p2eg::Cluster p2eg::getClusterFromRegion3x4(crystal (*)[20])':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1467:10: warning: implicitly-declared 'p2eg::Cluster::Cluster(const p2eg::Cluster&)' is deprecated [-Wdeprecated-copy]
  1467 |   return returnCluster;
      |          ^~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:856:14: note: because 'p2eg::Cluster' has user-provided 'p2eg::Cluster& p2eg::Cluster::operator=(const p2eg::Cluster&)'
  856 |     Cluster& operator=(const Cluster& rhs) {
      |              ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h: In function 'void p2eg::stitchClusterOverRegionBoundary(std::vector<Cluster>&, int, int, int)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1493:40: warning: implicitly-declared 'p2eg::Cluster::Cluster(const p2eg::Cluster&)' is deprecated [-Wdeprecated-copy]
  1493 |       p2eg::Cluster c1 = cluster_list[i];
      |                                        ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:856:14: note: because 'p2eg::Cluster' has user-provided 'p2eg::Cluster& p2eg::Cluster::operator=(const p2eg::Cluster&)'
  856 |     Cluster& operator=(const Cluster& rhs) {
      |              ^~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1494:40: warning: implicitly-declared 'p2eg::Cluster::Cluster(const p2eg::Cluster&)' is deprecated [-Wdeprecated-copy]
  1494 |       p2eg::Cluster c2 = cluster_list[j];
      |                                        ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:856:14: note: because 'p2eg::Cluster' has user-provided 'p2eg::Cluster& p2eg::Cluster::operator=(const p2eg::Cluster&)'
  856 |     Cluster& operator=(const Cluster& rhs) {
      |              ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloEGammaEmulator.cc: In member function 'virtual void Phase2L1CaloEGammaEmulator::produce(edm::Event&, const edm::EventSetup&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloEGammaEmulator.cc:384:51: warning: implicitly-declared 'p2eg::Cluster::Cluster(const p2eg::Cluster&)' is deprecated [-Wdeprecated-copy]
   384 |         p2eg::Cluster cExtra = cluster_list[cc][kk];
      |                                                   ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:856:14: note: because 'p2eg::Cluster' has user-provided 'p2eg::Cluster& p2eg::Cluster::operator=(const p2eg::Cluster&)'
  856 |     Cluster& operator=(const Cluster& rhs) {
      |              ^~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloEGammaEmulator.cc:525:67: warning: implicitly-declared 'p2eg::tower_t::tower_t(const p2eg::tower_t&)' is deprecated [-Wdeprecated-copy]
   525 |           p2eg::tower_t t0_ecal = towerECALCard[iTower][iLink][rcc];
      |                                                                   ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:692:14: note: because 'p2eg::tower_t' has user-provided 'p2eg::tower_t& p2eg::tower_t::operator=(const p2eg::tower_t&)'
  692 |     tower_t& operator=(const tower_t& rhs) {
      |              ^~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloEGammaEmulator.cc:526:67: warning: implicitly-declared 'p2eg::tower_t::tower_t(const p2eg::tower_t&)' is deprecated [-Wdeprecated-copy]
   526 |           p2eg::tower_t t0_hcal = towerHCALCard[iTower][iLink][rcc];
      |                                                                   ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:692:14: note: because 'p2eg::tower_t' has user-provided 'p2eg::tower_t& p2eg::tower_t::operator=(const p2eg::tower_t&)'
  692 |     tower_t& operator=(const tower_t& rhs) {
      |              ^~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloEGammaEmulator.cc:546:61: warning: implicitly-declared 'p2eg::Cluster::Cluster(const p2eg::Cluster&)' is deprecated [-Wdeprecated-copy]
   546 |         p2eg::Cluster c0 = cluster_list_merged[rcc][iCluster];
      |                                                             ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h:856:14: note: because 'p2eg::Cluster' has user-provided 'p2eg::Cluster& p2eg::Cluster::operator=(const p2eg::Cluster&)'
  856 |     Cluster& operator=(const Cluster& rhs) {
      |              ^~~~~~~~

PR validation:

Bot tests

cmsbuild · 2023-11-27T10:12:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43396/37896

This PR adds an extra 28KB to repository

cmsbuild · 2023-11-27T10:12:50Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

L1Trigger/L1CaloTrigger (l1, upgrade)

@cmsbuild, @srimanob, @epalencia, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

iarspider · 2023-11-27T10:26:16Z

please test

iarspider · 2023-11-27T10:29:15Z

please test for CMSSW_14_0_DEVEL_X

cmsbuild · 2023-11-27T12:58:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d67ddf/36079/summary.html
COMMIT: 8c367fb
CMSSW: CMSSW_14_0_X_2023-11-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43396/36079/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 113 lines to the logs
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3367918
DQMHistoTests: Total failures: 1113
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3366783
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

cmsbuild · 2023-11-27T13:09:30Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d67ddf/36080/summary.html
COMMIT: 8c367fb
CMSSW: CMSSW_14_0_DEVEL_X_2023-11-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43396/36080/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 121 lines to the logs
Reco comparison results: 18 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3367918
DQMHistoTests: Total failures: 1110
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3366786
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

aloeliger · 2023-11-30T10:18:24Z

+l1

srimanob · 2023-12-02T09:25:57Z

+Upgrade

cmsbuild · 2023-12-02T09:26:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2023-12-04T12:44:45Z

+1

cmsbuild added this to the CMSSW_14_0_X milestone Nov 27, 2023

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Nov 27, 2023

Fix Wdeprecated-copy warnings in L1Trigger/L1CaloTrigger

8c367fb

iarspider force-pushed the fix-deprecated-copy-l1calotrigger branch from b75c86f to 8c367fb Compare November 27, 2023 10:06

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 27, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 27, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 27, 2023

cmsbuild added l1-approved and removed l1-pending labels Nov 30, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Dec 2, 2023

cmsbuild added orp-approved and removed orp-pending labels Dec 4, 2023

cmsbuild merged commit 7a89141 into cms-sw:master Dec 4, 2023
17 checks passed

This was referenced Dec 4, 2023

Add recipe for pytorch (C++ interface only) cms-sw/cmsdist#8388

Merged

Fix deprecated-copy warnings in CondFormats/PhysicsToolsObjects and PhysicsTools/MVAComputer #43400

Merged

Phase2 Trigger Primitive generation for Ecal Barrel #42633

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix deprecated-copy warnings in L1Trigger/L1CaloTrigger #43396

Fix deprecated-copy warnings in L1Trigger/L1CaloTrigger #43396

iarspider commented Nov 27, 2023 •

edited

Loading

cmsbuild commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

iarspider commented Nov 27, 2023

iarspider commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

aloeliger commented Nov 30, 2023

srimanob commented Dec 2, 2023

cmsbuild commented Dec 2, 2023

antoniovilela commented Dec 4, 2023

Fix deprecated-copy warnings in L1Trigger/L1CaloTrigger #43396

Fix deprecated-copy warnings in L1Trigger/L1CaloTrigger #43396

Conversation

iarspider commented Nov 27, 2023 • edited Loading

PR description:

PR validation:

cmsbuild commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

iarspider commented Nov 27, 2023

iarspider commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

Comparison Summary

cmsbuild commented Nov 27, 2023

Comparison Summary

aloeliger commented Nov 30, 2023

srimanob commented Dec 2, 2023

cmsbuild commented Dec 2, 2023

antoniovilela commented Dec 4, 2023

iarspider commented Nov 27, 2023 •

edited

Loading