-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AlpakaTest tests to use their dependencies for controlling their execution, and extend module tests to ROCm. #43204
Conversation
…ution based on available hardware
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43204/37528
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@fwyzard, @makortel, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable gpu |
@cmsbuild, please test |
Is there a way to force running an alpaka-based test even if the corresponding backend is not available ?
|
-1 Failed Tests: RelVals-GPU GpuUnitTests RelVals-GPU
GPU Unit TestsI found 1 errors in the following unit tests: ---> test testHeterogeneousCoreAlpakaTestModulesCUDA had ERRORS Comparison SummarySummary:
|
The test failures look like the node had no GPU (probably the GPU setup of the node was incompatible with CUDA 12.2?). |
-1 Failed Tests: RelVals-GPU GpuUnitTests RelVals-GPU
GPU Unit TestsI found 1 errors in the following unit tests: ---> test testHeterogeneousCoreAlpakaTestModulesCUDA had ERRORS Comparison SummarySummary:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-973fa9/35704/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
The CPU comparison differences are related to #39803. The GPU comparison differences are in 12434.586 and 12434.587, 572 differences in both (on a cursory look limited to pixel tracks or derivatives). I guess this is within the normal variation of the GPU workflows? |
Unit test lists that both tests in |
@fwyzard @smuzaffar Do you have any further comments? |
No @makortel , nothing to add |
+heterogeneous |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following the discussion in #41340 this PR makes the
HeterogeneousCore/AlpakaTest
tests to use their dependencies to control their execution on various hardware. It also extends the Alpaka module tests to ROCm. It also adds a note on the unit tests to the README.Resolves cms-sw/framework-team#564
PR validation:
Unit tests run on a machine without a GPU, and on a machine with NVIDIA GPU. I was not able to test on AMD GPU.