Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2023 MC GT, VtxSmearing and PU library #42265

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR updates:

GT differences:

PR validation:

Tested with:
runTheMatrix.py -l 12434.0,12634.99 -j 8
I will let the bot tests all the other workflows.

Backport:

Not a backport, but 13_1_X and 13_0_X will be provided soon

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42265/36289

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@perrotta, @consuegs, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @sunilUIET, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e09909/33692/summary.html
COMMIT: 360b1b7
CMSSW: CMSSW_13_2_X_2023-07-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42265/33692/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 16 lines from the logs
  • Reco comparison results: 6339 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3193908
  • DQMHistoTests: Total failures: 13606
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3180280
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@tvami
Copy link
Contributor

tvami commented Jul 14, 2023

+alca

@srimanob
Copy link
Contributor

Thanks @francescobrivio for the PR.

Note to @cms-sw/pdmv-l2 @cms-sw/alca-l2
We should also update 2023FS

If @cms-sw/pdmv-l2 can generate MinBias and TTbar with new BS, I can make a PR later to final this update on FastSim. Thx.

@srimanob
Copy link
Contributor

+Upgrade

Update for FullSim 2023. FastSim to be followed up.

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c40e9aa into cms-sw:master Jul 15, 2023
@sunilUIET
Copy link
Contributor

Thanks @francescobrivio for the PR.

Note to @cms-sw/pdmv-l2 @cms-sw/alca-l2 We should also update 2023FS

If @cms-sw/pdmv-l2 can generate MinBias and TTbar with new BS, I can make a PR later to final this update on FastSim. Thx.

Hi @srimanob , To be sure :). FastSim WFs are required in 12_4_14 with only a change of beamspot to Realistic25ns13p6TeVEarly2023Collision. Right?

@srimanob
Copy link
Contributor

Why 12_4?
I propose to have in master, then backport to 13_0. So we can organize the FastSim-FullSim 2023 in the same release.

@sunilUIET
Copy link
Contributor

Why 12_4? I propose to have in master, then backport to 13_0. So we can organize the FastSim-FullSim 2023 in the same release.

@srimanob Ok thanks! We will produce MinBias and TTbar with Realistic25ns13p6TeVEarly2023Collision in 13_2_0_pre3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants