Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0.X] add specialized ZeroBias relval steps and use them for 2022 data workflows, in order to employ @rerecoZeroBias DQM sequence #42063

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 23, 2023

backport of #42031

PR description:

Title says it all. It was recently re-discovered that in the 2022 data workflows since the @standardDQM* sequence is run also in the ZeroBias PDs there is no dedicated trigger bits filtering in the Tracker and Tracking sequences, leading (among other things) to have plots of track multiplicity in which there are events with no tracks, see for example:

image

coming from the recent 2023Bvs2023C PdmV campaign.
In this PR I correct the situation by specializing the ZeroBias workflows to run a DQM sequence which contains the @rerecoZeroBias* instead in the first and harvesting DQM step.
This would help using ZeroBias consistently in the future data release validations.

PR validation:

none.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

partial backport of #42031 to 13.0.X

…m for 2022 data workflows, in order to employ the @rerecoZeroBias DQM sequence
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 23, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 23, 2023

test parameters:

  • workflows = 140.003,140.023,140.043,140.063,140.072,140.104

@mmusich
Copy link
Contributor Author

mmusich commented Jun 23, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-346257/33349/summary.html
COMMIT: aa3d471
CMSSW: CMSSW_13_0_X_2023-06-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42063/33349/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 464 lines from the logs
  • Reco comparison results: 29 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 3741521
  • DQMHistoTests: Total failures: 11231
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3730268
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -73051.925 KiB( 53 files compared)
  • DQMHistoSizes: changed ( 140.003,... ): 14483.488 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 140.003,... ): -12323.616 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 140.003,... ): -10390.469 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 140.003,... ): -8697.605 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 140.003,... ): 3543.336 KiB Tracking/V0Monitoring
  • DQMHistoSizes: changed ( 140.003,... ): -1760.337 KiB HLT/EXO
  • DQMHistoSizes: changed ( 140.003,... ): 1162.402 KiB L1TEMU/L1TObjects
  • DQMHistoSizes: changed ( 140.003,... ): 1160.753 KiB L1T/L1TObjects
  • DQMHistoSizes: changed ( 140.003,... ): -849.901 KiB HLT/EGM
  • DQMHistoSizes: changed ( 140.003,... ): -825.682 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 140.003 ): ...
  • Checked 237 log files, 183 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@sunilUIET
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5c38dc1 into cms-sw:CMSSW_13_0_X Jun 26, 2023
@mmusich mmusich deleted the rerecoZB_run3_relvals_13_0_X branch June 26, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants