Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL: Updates to match HCAL TDC LUT deployed online June 12 #42023

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

gk199
Copy link
Contributor

@gk199 gk199 commented Jun 20, 2023

PR description:

Updating the HCAL TDC LUTs for HB to match the TDC LUT deployed online on June 12. This is needed for HB TDC emulation and fine grain bit emulation to match the online settings. Elog for the TDC LUT update: http://cmsonline.cern.ch/cms-elog/1186628. This PR simply edits the existing LUT implementation in CMSSW to match online conditions.

TDC LUTs not anticipated to be changed in Run 3.

PR validation:

Tested in CMSSW_13_2_X_2023-06-15-2300, runTheMatrix.py passed.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42023/35982

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gk199 (Gillian Kopp) for master.

It involves the following packages:

  • EventFilter/HcalRawToDigi (reconstruction)
  • SimCalorimetry/HcalTrigPrimAlgos (l1)

@epalencia, @cmsbuild, @mandrenguyen, @aloeliger, @clacaputo can you please review it and eventually sign? Thanks.
@missirol, @rovere, @Martin-Grunewald, @bsunanda, @sameasy, @abdoulline this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8208a6/33268/summary.html
COMMIT: 80f9d66
CMSSW: CMSSW_13_2_X_2023-06-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42023/33268/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197958
  • DQMHistoTests: Total failures: 172
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197764
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@mandrenguyen
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants