Fixed channel decoding for the timeout error in SiPixel RawToDigi

[ferencek]

PR description:

Making PR for Danek. This PR addresses #41715

CPU code:

• Wrong channel decoding for TO (Timeout) error. All TO errors are missed.
• Reason – ErrorChecker::checkROC() skips the 1st TO word (return), PixelDataFormatter skips the 2nd one (if(link,roc)). So, none is processed.

GPU code:

• Both TO words are processed, but often ErrorChecker::errorDetId() gives a wrong DetId, the channel identification is usually wrong, so either a dummyID is returned or another (incorrect) module.

Correction:

• Change from errorDetId() to errorDetIdSimple() in ErrorChecker.cc .
• Modify the word select for TO errors in ErrorChecker::checkROC() (if statement).

PR validation:

Code compiles :)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backports to 13_1_X and 13_0_X foreseen.

@dkotlins @mmusich

[mmusich]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42010/35972

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko F.) for master.

It involves the following packages:

• EventFilter/SiPixelRawToDigi (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mroguljic, @VinInn, @Martin-Grunewald, @missirol, @dkotlins, @ferencek, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• enable_tests = gpu
• workflows_gpu = 10824.507
• relvals_opt= -w upgrade
• relvals_opt_gpu = -w upgrade

[mmusich]

@cmsbuild, please test

[mmusich]

@ferencek in the meanwhile can you update the PR title, such that it's immediately clear the fix is in the sipixel raw2digi?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1fda3/33234/summary.html
COMMIT: e770f71
CMSSW: CMSSW_13_2_X_2023-06-18-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42010/33234/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 694 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196062
• DQMHistoTests: Total failures: 2223
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193817
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 56220
• DQMHistoTests: Total failures: 38
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 56182
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

[mmusich]

urgent

• might resolve issue at Large GPU/CPU difference in soft electron reconstruction related to pixel unpacker #41715

[jordan-martins]

Hi @perrotta and @rappoccio,

Please, let's merge this. This should be in for the startup of ERA D after the TS1. This means we need to have a release ready by Thursday evening/ Friday morning, so a replay at T0 can be deployed on Friday and be ready to be migrated on Monday (Jun. 26th). A backport should come soon to be considered for the new 130X release.

Also, I'd like to let you know that another PR for mitigation on the GPU side should also come by today, latest, tomorrow. This would close the mitigation loop on the need for both Online and Offline matters regarding the pixel Unpacker matters while handling errors. A backport for 130X should come as well.

Thanks,
Jordan
FYI @silviodonato @missirol @goys @malbouis @mmusich @sroychow @cms-sw/reconstruction-l2 @saumyaphor4252

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Assuming the differences in workflows 10824.507 , 12434.586 , 12434.587 have been evaluated and look as expected: please someone confirm before merging the backports