Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PileUpJetID] Move average calculations outside of jet constituents loop #41854

Merged

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR moves the average values calculations to outside of the jet constituents loop in PileupJetIdAlgo.cc.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

Backport:

To be backported to 13_1_X, 13_0_X and 12_6_X(in another backport PR #40802).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41854/35757

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

  • RecoJets/JetProducers (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @missirol, @yslai, @AnnikaStein, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jun 4, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe1ed3/32965/summary.html
COMMIT: c4b3672
CMSSW: CMSSW_13_2_X_2023-06-04-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41854/32965/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221457
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221429
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

type performance-improvements

@mandrenguyen
Copy link
Contributor

type jetmet

@cmsbuild cmsbuild added the jetmet label Jun 5, 2023
@mandrenguyen
Copy link
Contributor

+reconstruction
Code speed up, no change to reco

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jun 5, 2023

+1

@cmsbuild cmsbuild merged commit 045e68f into cms-sw:master Jun 5, 2023
cmsbuild added a commit that referenced this pull request Jun 6, 2023
…avgOutOfLoop

[PileUpJetID] Backport of #41854 (Move average calculations outside of jet constituents loop) to 13_0_X
cmsbuild added a commit that referenced this pull request Jun 6, 2023
…avgOutOfLoop

[PileUpJetID] Backport of #41854 (Move average calculations outside of jet constituents loop) to 13_1_X
@nurfikri89 nurfikri89 deleted the from1320pre1_puIdFix_avgOutOfLoop branch June 7, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants