Update of Strip hit efficiency code output

[jlagram]

PR description:

Small changes to SiStripHitEffFromCalibTree.cc:

• add the possibility as an option to output the efficiencies for each module, not only layer average
  -> additional tree in the output root file
• add PU/lumi distributions including the effect of the event selection based on track multiplicity
  -> additional histos in the output root file

PR validation:

Ran the code and checked output content.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41845/35746

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @jlagram for master.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf7a0b/32946/summary.html
COMMIT: 80b1fec
CMSSW: CMSSW_13_2_X_2023-06-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41845/32946/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

[tvami]

so CLANG wants this to be initialized
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf7a0b/32946/new-build-warnings.log

[tvami]

hi @jlagram after fixing the CLANG warning, please squash the commits and modify the PR title to be a bit more descriptive. Thanks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41845/35773

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #41845 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

[mmusich]

@cmsbuild, please test

[tvami]

hi @jlagram after fixing the CLANG warning, please squash the commits and modify the PR title to be a bit more descriptive. Thanks

Thanks for fixing the warning and the PR title change. Please dont forget about the squash either

[tvami]

+alca

• last push is just a squash

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41845/35795

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #41845 was updated. can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf7a0b/32997/summary.html
COMMIT: 7391a6d
CMSSW: CMSSW_13_2_X_2023-06-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41845/32997/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 22 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3219909
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219887
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+1