-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of Strip hit efficiency code output #41845
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41845/35746
|
A new Pull Request was created by @jlagram for master. It involves the following packages:
@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: Build BuildI found compilation warning when building: See details on the summary page. |
@@ -1004,6 +1034,22 @@ void SiStripHitEffFromCalibTree::makeHotColdMaps() { | |||
|
|||
void SiStripHitEffFromCalibTree::makeTKMap(bool autoTagging = false) { | |||
LOGPRINT << "Entering TKMap generation!\n"; | |||
|
|||
TTree* tree; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so CLANG wants this to be initialized
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf7a0b/32946/new-build-warnings.log
hi @jlagram after fixing the CLANG warning, please squash the commits and modify the PR title to be a bit more descriptive. Thanks |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41845/35773
|
Pull request #41845 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again. |
@cmsbuild, please test |
Thanks for fixing the warning and the PR title change. Please dont forget about the squash either |
New distributions for PU info after cut on number of tracks Fix a warning
24b93fd
to
7391a6d
Compare
+alca
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41845/35795
|
Pull request #41845 was updated. can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf7a0b/32997/summary.html Comparison SummarySummary:
|
+1 |
PR description:
Small changes to SiStripHitEffFromCalibTree.cc:
-> additional tree in the output root file
-> additional histos in the output root file
PR validation:
Ran the code and checked output content.