-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1T: updates for firmware testing and unpacker update #41685
Conversation
bundocka
commented
May 15, 2023
- Updates CaloL2 MP unpacker to use correct jet quality bit
- Various updates to the CaloL2 firmware testing code
- Update the script that converts the offline calorimeter LUTs to the online xml files
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41685/35556
|
A new Pull Request was created by @bundocka for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -227,7 +227,7 @@ namespace l1t { | |||
jet.setHwEta(CaloTools::caloEta(mpEta)); | |||
jet.setHwPhi((raw_data >> 6) & 0x7F); | |||
jet.setHwPt((raw_data >> 13) & 0xFFFF); | |||
jet.setHwQual((raw_data >> 29) & 0x1); | |||
jet.setHwQual((raw_data >> 30) & 0x1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, does this change mean that the current unpacker is reading the wrong quality bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but this is the MP unpacker, so it isn't used anywhere (except for local firmware testing). the demux unpacker correctly unpacks the jet quality already, and is used for DQM, L1 Ntuples etc.
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a0c34/32650/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |