Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1T: updates for firmware testing and unpacker update #41685

Merged
merged 1 commit into from
May 16, 2023
Merged

L1T: updates for firmware testing and unpacker update #41685

merged 1 commit into from
May 16, 2023

Conversation

bundocka
Copy link
Contributor

  • Updates CaloL2 MP unpacker to use correct jet quality bit
  • Various updates to the CaloL2 firmware testing code
  • Update the script that converts the offline calorimeter LUTs to the online xml files

@cmsbuild cmsbuild added this to the CMSSW_13_2_X milestone May 15, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41685/35556

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bundocka for master.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)
  • L1Trigger/L1TCalorimeter (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @Martin-Grunewald, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

aloeliger
aloeliger reviewed May 15, 2023
View reviewed changes
EventFilter/L1TRawToDigi/plugins/implementations_stage2/MPUnpacker_0x10010033.cc
@@ -227,7 +227,7 @@ namespace l1t {
jet.setHwEta(CaloTools::caloEta(mpEta));
jet.setHwPhi((raw_data >> 6) & 0x7F);
jet.setHwPt((raw_data >> 13) & 0xFFFF);
jet.setHwQual((raw_data >> 29) & 0x1);
jet.setHwQual((raw_data >> 30) & 0x1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, does this change mean that the current unpacker is reading the wrong quality bit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but this is the MP unpacker, so it isn't used anywhere (except for local firmware testing). the demux unpacker correctly unpacks the jet quality already, and is used for DQM, L1 Ntuples etc.

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a0c34/32650/summary.html
COMMIT: 3d74c46
CMSSW: CMSSW_13_2_X_2023-05-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41685/32650/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3461474
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461449
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5924544 into cms-sw:master May 16, 2023
@cmsbuild cmsbuild mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloeliger aloeliger aloeliger left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_2_X
Development

Successfully merging this pull request may close these issues.
4 participants
@bundocka @cmsbuild @aloeliger @perrotta