-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mismatched array bounds in tracklet displaced calculator function signature #41683
Conversation
Thanks @aloeliger! |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41683/35555
|
A new Pull Request was created by @aloeliger (Andrew Loeliger) for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
indeed, this seems like a straight out bug that somehow has not been caught before! thank you for fixing @aloeliger FYI @tomalin @gershtein |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec96e1/32647/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes mismatched array sizes in TrackletCalculatorDisplaced.cc and TrackletCalculatorDisplaced.h for the
TrackletCalculatorDisplaced::exacttracklet
function signature. Not having original knowledge of this function, I have replaced the implementation array sizes with the header declared sizes. @skinnari you are listed as the original author of these lines, would you please confirm that this is okay with you.This PR (in theory) closes #41677. @aandvalenzuela I figured you might like to be informed.
PR validation:
All code builds, has had formatting applied, and passes existing code checks.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport