Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatched array bounds in tracklet displaced calculator function signature #41683

Merged
merged 1 commit into from
May 15, 2023

Conversation

aloeliger
Copy link
Contributor

PR description:

This PR fixes mismatched array sizes in TrackletCalculatorDisplaced.cc and TrackletCalculatorDisplaced.h for the TrackletCalculatorDisplaced::exacttracklet function signature. Not having original knowledge of this function, I have replaced the implementation array sizes with the header declared sizes. @skinnari you are listed as the original author of these lines, would you please confirm that this is okay with you.

This PR (in theory) closes #41677. @aandvalenzuela I figured you might like to be informed.

PR validation:

All code builds, has had formatting applied, and passes existing code checks.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport

@aandvalenzuela
Copy link
Contributor

Thanks @aloeliger!

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41683/35555

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aloeliger (Andrew Loeliger) for master.

It involves the following packages:

  • L1Trigger/TrackFindingTracklet (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @erikbutz, @skinnari, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor Author

please test

@skinnari
Copy link
Contributor

indeed, this seems like a straight out bug that somehow has not been caught before! thank you for fixing @aloeliger

FYI @tomalin @gershtein

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec96e1/32647/summary.html
COMMIT: de08678
CMSSW: CMSSW_13_2_X_2023-05-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41683/32647/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3461474
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461446
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor Author

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[L1] [CLANG] mismatched bound arrays warnings
5 participants