do not allow crashes in isEmpty(int bx) method of BXVector [13_0_X]

[missirol]

backport of #41572

PR description:

From the description of #41572:

This PR aims to make the method BXVector::isEmpty(int bx) more robust, removing the possibility of runtime crashes when this method is called.

This public method can currently crash if the value of its bx argument is outside the range of valid BXs, or if the itrs_ class member is empty (as seen in the problematic events that led to the crashes fixed by #41466).

PR validation:

None beyond the checks done for #41572.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#41572

Fix to public method used by several plugins in CMSSW.

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

• DataFormats/L1Trigger (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @rovere, @kreczko, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from do not allow crashes in isEmpty(int bx) method of BXVector #41572

[missirol]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16cf10/32440/summary.html
COMMIT: e6b2866
CMSSW: CMSSW_13_0_X_2023-05-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41574/32440/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTower.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTowerMap.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTriggerCell.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTriggerSums.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTowerMap.cc: In member function 'const l1t::HGCalTowerMap& l1t::HGCalTowerMap::operator+=(const l1t::HGCalTowerMap&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTowerMap.cc:18:12: error: 'endl' was not declared in this scope; did you mean 'std::endl'?
   18 |         << endl;
      |            ^~~~
      |            std::endl
In file included from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/istream:39,
                 from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/sstream:38,


[cmsbuild]

Pull request #41574 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again.

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16cf10/32446/summary.html
COMMIT: 24017c3
CMSSW: CMSSW_13_0_X_2023-05-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41574/32446/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 21 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554764
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554739
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1