Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve implementation of HLTJetTag<T> plugin template [13_1_X] #41530

Merged
merged 1 commit into from
May 19, 2023

Conversation

missirol
Copy link
Contributor

@missirol missirol commented May 4, 2023

backport of #41351

PR description:

From the description of #41351 :

This PR aims to improve the plugin template HLTJetTag<T> as follows.

  1. Add option to match jets by delta-R (the plugin uses two jet collections: the first one is a simple jet collection, the second one is the "key" of a JetTagCollection whose values as the jet b-tagging scores).
  2. If delta-R matching is not used (not using delta-R matching remains the default behaviour), the (b-)tag value of the jet is accessed via the method edm::AssociationVector::operator[]. This requires that the input jet collection is the same as the "key" collection of the JetTagCollection. If this is not the case, the plugin will throw an exception at runtime.

The limits of the current implementation of HLTJetTag<T> were discussed in #41045.

PR validation:

None beyond the checks done for #41351.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#41351

Backport of an HLT-related update needed down to 13_0_X (i.e. the release cycle used for 2023 pp data-taking).

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_1_X.

It involves the following packages:

  • HLTrigger/btau (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @silviodonato, @AnnikaStein, @Martin-Grunewald, @JyothsnaKomaragiri, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #41530 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ba40f/32687/summary.html
COMMIT: c7dfe93
CMSSW: CMSSW_13_1_X_2023-05-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41530/32687/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222422
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3222388
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c13aace into cms-sw:CMSSW_13_1_X May 19, 2023
@missirol missirol deleted the devel_fix41045_step2 branch July 4, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants