-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prototype HcalNanoAOD #40489
Add prototype HcalNanoAOD #40489
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40489/33666
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40489/33793
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
5c086e1
to
4ae3163
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40489/33814
|
A new Pull Request was created by @DryRun (David Yu) for master. It involves the following packages:
The following packages do not have a category, yet: DPGAnalysis/HcalNanoAOD @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
assign xpog |
enable nano |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e121db/30738/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
@DryRun please amend the PR description accordingly |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40489/34495
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
0b8a497
to
5938216
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40489/34496
|
Done. I made an additional commit to support running over HCAL local runs (hopefully the last feature modification in this PR, we should put additional features into the next PR). |
can you please add a test workflow in the matrix, like was done for #41245, so that we keep a eye on this alternative nano configuration |
@jhakala added a test workflow. I rebased the PR to 13_1_0_pre4 and renamed the branch accordingly, but seem to have caused this PR to close permanently, similar to isaacs/github#361. I think it's easiest to make a new PR (#41607), but please advise if I should try to recover this one. |
PR description:
Prototype implementation for use by HCAL DPG, not ready for merging yet
This PR implements a NanoAOD format for HCAL digis and RecHits. This data format is intended to replace the old HcalTupleMaker used by most HCAL workflows.
Example:
RecHits are implemented following @kdlong's PFNano branch, https://github.com/kdlong/cmssw/tree/pfNano_HCALOnly_12_6_0_pre4. The specific modules, however, are defined in
DPGAnalysis/HcalNanoAOD
(e.g.HBHERecHitFlatTableProducer
), rather thanDPGAnalysis/CaloNanoAOD
(e.g.SimpleCaloRecHitFlatTableProducer
). Hence, this package is independent ofDPGAnalysis/CaloNanoAOD
.Digis are handled by dedicated modules in
DPGAnalysis/HcalNanoAOD
that output dense arrays, sorted by DetId. A list of the DetIds (i.e. the column labels) is placed inRun
. For the moment, DetIds are also saved inEvent
, for development purposes although we might decide to keep them for ease of analysis.Metadata from the uMNio, namely the labeling of calibration events (pedestal/LED/laser) and which type of laser event, is also handled by a dedicated module.
Two customization functions are provided for special datasets:
hcalNano_cff.customiseHcalCalib
: for calibration sequence events in the TestEnablesEcalHcal dataset (i.e. events in the abort gap of type pedestal, LED, or laser). Specifies the correct label for the raw data; adds uMNio metadata; adds an important HLT filter to all Paths and Endpaths, which selects events triggered by HLT_HcalCalibration. This filter essential to avoid a crash, because ECAL-triggered events are missing the HCAL raw data collection (aside: HCAL needs to revisit the definition of this dataset; the trigger is based on a majority-wins vote of calibration flags from the HCAL uHTRs. A single uHTR flagging the event as calibration should be enough to consider the event calibration and not real physics!).hcalNano_cff.customiseHcalLocal
: for HCAL local runs. Loads the raw data usingHcalTBSource
; adjusts the number of time slices per digi; adds uMNio metadata.TBD: trigger primitives.
PR validation:
Produces useful HCAL NanoAOD ntuples. Data validated event-by-event against HcalTupleMaker. Calibration and local run customization functions work on recent MWGR 2023 data.
Other
The contents of this PR are ready for use by HCAL DPG right away. An eventual merge should take into account @kdlong's PFNanoAOD branch, but this package is independent of
DPGAnalysis/CaloNanoAOD
.@mariadalfonso @wang-hui