Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements to Alignment/OfflineValidation #40222

Merged
merged 7 commits into from
Dec 4, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 2, 2022

PR description:

This PR contains some minor clean-ups post #38304 merge.
Commits featured:

PR validation:

Run the unit tests of this package successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40222/33262

  • This PR adds an extra 96KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/CommonAlignment (alca)
  • Alignment/OfflineValidation (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 2, 2022

please test

@tvami
Copy link
Contributor

tvami commented Dec 2, 2022

the unit test is failing with

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2022-12-02-1100/src/Alignment/OfflineValidation/test/testTrackAnalyzers.cc:21: FAILED:
  REQUIRE_NOTHROW( edm::test::TestProcessor(config) )
due to unexpected exception with message:
  An exception of category 'Configuration' occurred.
  Exception Message:
   unknown python problem occurred.
  ModuleNotFoundError: No module named 'Alignment.OfflineValidation.
  GeneralPurposeTrackAnalyzer_cfi'
  
At:
    <string>(3): <module>

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40222/33267

  • This PR adds an extra 100KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

Pull request #40222 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 2, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba21e3/29430/summary.html
COMMIT: c27ada7
CMSSW: CMSSW_13_0_X_2022-12-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40222/29430/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 250204.0DAS Error

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421134
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Dec 2, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40222/33279

  • This PR adds an extra 100KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2022

Pull request #40222 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 3, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba21e3/29443/summary.html
COMMIT: 0abf7bb
CMSSW: CMSSW_13_0_X_2022-12-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40222/29443/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 33 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421337
  • DQMHistoTests: Total failures: 1192
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3420123
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Dec 3, 2022

ping @cms-sw/alca-l2 @cms-sw/orp-l2

DQMHistoTests: Total failures: 1192

None of these changes can come from this PR

@tvami
Copy link
Contributor

tvami commented Dec 4, 2022

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Dec 4, 2022

+1

@cmsbuild cmsbuild merged commit ef3151a into cms-sw:master Dec 4, 2022
@mmusich mmusich deleted the AliOfflineValidImprovAndSA branch December 4, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants