Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlCaReco producers in phase-2 workflows [12.5.X] #39898

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 28, 2022

backport of #39858 and #39917

PR description:

The goal of this PR is to start exercising Tracker alcareco producers in the phase-2 workflows, as there is interest in trying a preliminary alignment with the phase-2 geometry.
A minimal set of changes if proposed in order to achieve that goal, including the necessary update of the phase2_realistic autoCond key in order to get most updated trigger bits from the run-3 global tag (see also cmsTalk):

In addition the pseudo-rapidity range of the alignment alcarecos is modified in the case of the phase-2 tracker to allow full coverage (up to |η|<4).

PR validation:

Run successfully runTheMatrix.py -l 20834.0 -t 4 -j 8

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #39858 and #39917 (excepted changes in upgradeWorkflowComponents.py concerning D95 and D96 that dont't exist in this cycle).
Needed to run the ALCARECO skimming on top the phase-2 samples production from L1T group (Phase2Fall22DRMiniAOD)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_5_X.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)
  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • RecoTracker/TransientTrackingRecHit (reconstruction)

@malbouis, @ChrisMisan, @yuanchao, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @kpedro88, @Martin-Grunewald, @tlampen, @trtomei, @slomeo, @pakhotin, @makortel, @JanFSchulte, @dgulhan, @missirol, @beaucero, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @mmusich, @mtosi, @fabiocos, @adewit, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 28, 2022

please test

@cmsbuild
Copy link
Contributor

Pull request #39898 was updated. @malbouis, @ChrisMisan, @yuanchao, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @tvami, @mandrenguyen, @francescobrivio can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 28, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98db58/28615/summary.html
COMMIT: 77ad200
CMSSW: CMSSW_12_5_X_2022-10-28-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39898/28615/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3288560
  • DQMHistoTests: Total failures: 137
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3288401
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 195 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+alca

  • I see some differences (not present in the master PR) in 11634.7 which is not Phase-II and does not run any ALCA sequence (as far as i can see), so the PR is ok from the alca point of view

@francescobrivio
Copy link
Contributor

francescobrivio commented Oct 29, 2022

* I see some differences (not present in the master PR) in 11634.7 which is not Phase-II and does not run any ALCA sequence (as far as i can see), so the PR is ok from the `alca` point of view

I just realized this is a know issue: #39803

@srimanob
Copy link
Contributor

+Upgrade

This PR will allow us to run ALCAReco step with L1T campaign. It does not touch the main RECO sequence, so it should be to be backported.

@mandrenguyen
Copy link
Contributor

backport of #39858
checking if the backport label wasn't triggered b/c two PRs were specified

@mandrenguyen
Copy link
Contributor

+reconstruction

@mmusich
Copy link
Contributor Author

mmusich commented Oct 31, 2022

@cms-sw/pdmv-l2 kind ping

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

  • Near verbatim backport, needed for phase 2 MC production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants