-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to cut H<a+bE+cE*E backport to 12_5_X #39793
Add option to cut H<a+bE+cE*E backport to 12_5_X #39793
Conversation
A new Pull Request was created by @bennettgberg for CMSSW_12_5_X. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
backport of #39762 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ff86b/28394/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Removed the signature for now. Strange differences in wf |
please test |
Thanks for the info. This confirms they are unrelated to HLT updates, b/c #39772 cannot cause them by construction. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ff86b/28405/summary.html Comparison SummarySummary:
|
+hlt
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Interestingly, the bot didn't merge the PR.. (okay, now yes) |
PR description:
Backport to 12_5_X for: #39762
Adds an option to change the H/E cut to take the form H<a+bE+cE^2 for constants a, b, c.
This will be needed for Egamma objects in upcoming changes to the Scouting trigger.
Default behavior stays unchanged.
In particular, slide 10 shows the physics motivation--large increase in low-pT scouting electron signal reconstruction efficiency resulting from changing this cut.
PR validation:
Tested with scram b code-checks and scram b code-format. Further tests performed locally showing expected behavior of the code changes--namely, when doAnd is set to true with non-zero values for cut and cutOverE specified, all resulting scouting electrons in the collection obey H < cutOverE*E + cut and the number of these electrons is reasonable.
Tested in CMSSW_12_5_1 successfully with new 'doAnd' variable set to both True and False.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport to 12_5_X for: #39762
Needed for possible testing of new Scouting menu at end of 2022 data-taking.