Add option to cut H<a+bE+cE*E backport to 12_5_X

[bennettgberg]

PR description:

Backport to 12_5_X for: #39762

Adds an option to change the H/E cut to take the form H<a+bE+cE^2 for constants a, b, c.
This will be needed for Egamma objects in upcoming changes to the Scouting trigger.
Default behavior stays unchanged.

• No changes in output
• No external dependencies
• slides presented to TSG on the change in Scouting: https://indico.cern.ch/event/1186562/contributions/4992593/attachments/2489115/4274414/electronScouting_22-08-03.pdf
  In particular, slide 10 shows the physics motivation--large increase in low-pT scouting electron signal reconstruction efficiency resulting from changing this cut.

PR validation:

Tested with scram b code-checks and scram b code-format. Further tests performed locally showing expected behavior of the code changes--namely, when doAnd is set to true with non-zero values for cut and cutOverE specified, all resulting scouting electrons in the collection obey H < cutOverE*E + cut and the number of these electrons is reasonable.

Tested in CMSSW_12_5_1 successfully with new 'doAnd' variable set to both True and False.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to 12_5_X for: #39762
Needed for possible testing of new Scouting menu at end of 2022 data-taking.

[cmsbuild]

A new Pull Request was created by @bennettgberg for CMSSW_12_5_X.

It involves the following packages:

• RecoEgamma/EgammaHLTProducers (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Sam-Harper, @HuguesBrun, @silviodonato, @jainshilpi, @sameasy, @valsdav, @Fedespring, @lgray, @missirol, @sobhatta, @afiqaize, @wrtabb, @Prasant1993, @varuns23, @cericeci, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Add option to cut H<a+bE+cE*E #39762

[missirol]

please test

[missirol]

backport of #39762

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ff86b/28394/summary.html
COMMIT: d88d911
CMSSW: CMSSW_12_5_X_2022-10-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39793/28394/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3697216
• DQMHistoTests: Total failures: 998
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3696196
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[missirol]

Removed the signature for now. Strange differences in wf 11634.7. Likely unrelated to this PR, but we might want to rerun the tests, unless it is a known issue.

[perrotta]

please test
(let retrigger the tests, even though the differences in wf 11634.7 did not show up in the master version of this PR, nor in the 12_4_X backport)

[perrotta]

@missirol I was probably a bit too precipituous in relaunching the tests: the same differences in the same wf are also present in the unrelated PR #39772

[missirol]

Thanks for the info. This confirms they are unrelated to HLT updates, b/c #39772 cannot cause them by construction.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ff86b/28405/summary.html
COMMIT: d88d911
CMSSW: CMSSW_12_5_X_2022-10-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39793/28405/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3697216
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697192
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

• after re-running the PR tests, spurious differences in wf 11634.7 have disappeared (and this PR really isn't expected to lead to any differences, as the default behaviour of the plugin updated here is unchanged)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[missirol]

Interestingly, the bot didn't merge the PR..

(okay, now yes)