Fix assertion in cluster remover

[mmusich]

resolves issue #39255

PR description:

See description at #39255 (comment) , undo #39233 and implementing #37384 (comment).

PR validation:

See description at #39255 (comment)

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39313/32004

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39313/32004/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39313/32004/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mmusich]

test parameters:

• enable_test = threading
• workflows_threading = 1325.2,1325.3,10024.4,31434.0,32234.0,39434.9

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39313/32007

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• RecoTracker/FinalTrackSelectors (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ce348/27359/summary.html
COMMIT: f001ce7
CMSSW: CMSSW_12_6_X_2022-09-05-2300/el8_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39313/27359/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3618210
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618183
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

@mmusich Are you waiting for something in particular to remove the draft label?

[mmusich]

Are you waiting for something in particular to remove the draft label?

I didn't check explicitly again that it solves the problem in the UB build. I am reluctant to launch the tests with that flag here because last time it was not really cooperating. Perhaps a second pair of eyes could check that as well.

[rappoccio]

@mandrenguyen did you get a chance to check into this one? The IBs are still failing.

[mandrenguyen]

+reconstruction
Was verified to fix assertion failure.
No change observed in comparisons.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Let see the effect on the next IB