-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assertion in cluster remover #39313
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39313/32004
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
d4ab568
to
f001ce7
Compare
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39313/32007
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ce348/27359/summary.html Comparison SummarySummary:
|
@mmusich Are you waiting for something in particular to remove the draft label? |
I didn't check explicitly again that it solves the problem in the UB build. I am reluctant to launch the tests with that flag here because last time it was not really cooperating. Perhaps a second pair of eyes could check that as well. |
@mandrenguyen did you get a chance to check into this one? The IBs are still failing. |
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
resolves issue #39255
PR description:
See description at #39255 (comment) , undo #39233 and implementing #37384 (comment).
PR validation:
See description at #39255 (comment)