-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of workflow for release validation with data #39265
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39265/31914
|
A new Pull Request was created by @sunilUIET (sunil bansal) for master. It involves the following packages:
@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@@ -457,8 +457,26 @@ | |||
workflows[139.005] = ['',['AlCaPhiSym2021','RECOALCAECALPHISYMDR3','ALCAECALPHISYM']] | |||
|
|||
### run3 (2022) ### | |||
workflows[140.001] = ['',['RunMinimumBias2022B','HLTRUN3','RECONANORUN3','HARVESTRUN3']] | |||
workflows[140.002] = ['',['RunZeroBias2022B','HLTRUN3','RECONANORUN3','HARVESTRUN3']] | |||
workflows[140.001] = ['',['RunZeroBias2022B','HLTRUN3','RECONANORUN3','HARVESTRUN3']] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to switch the workflow of ZeroBias and MinBias here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, actually this is totally accidental and realized after creating PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, Please fix. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srimanob I made the changes. Please see if these are correctly propagated to the PR.
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39265/31926
|
Pull request #39265 was updated. @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please check and sign again. |
@cmsbuild please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
It seems to be a glitch on PR test, not relate to this PR. The issue on RelVal-INPUT, as I see 2 of them, they found the file, but did not run until the end. |
@cmsbuild please test To see if we can clean up the relval-input issue. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b32d18/27247/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade New data workflows run fine. |
+pdmv Thanks @srimanob for the prompt review! |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is for the addition of Run3 WFs (140.003 - 140.005, 140.015 - 140.020, 140.031 - 140.036) for the release validation with data
PR validation:
Changes have been on top of CMSSW_12_6_0_pre1 and the aforementioned WFs are tested using
runTheMatrix.py --what standard -l 140.003,140.004,140.005,140.015,140.016,140.017,140.018,140.019,140.020,140.031,140.032,140.033,140.034,140.035,140.036 -t 4 --command='-n 10'
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport