Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of workflow for release validation with data #39265

Merged
merged 3 commits into from
Sep 1, 2022

Conversation

sunilUIET
Copy link
Contributor

PR description:

This PR is for the addition of Run3 WFs (140.003 - 140.005, 140.015 - 140.020, 140.031 - 140.036) for the release validation with data

PR validation:

Changes have been on top of CMSSW_12_6_0_pre1 and the aforementioned WFs are tested using
runTheMatrix.py --what standard -l 140.003,140.004,140.005,140.015,140.016,140.017,140.018,140.019,140.020,140.031,140.032,140.033,140.034,140.035,140.036 -t 4 --command='-n 10'

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39265/31914

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sunilUIET (sunil bansal) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

test parameters:

  • workflows = 140.003,140.004,140.005,140.015,140.016,140.017,140.018,140.019,140.020,140.031,140.032,140.033,140.034,140.035,140.036

@@ -457,8 +457,26 @@
workflows[139.005] = ['',['AlCaPhiSym2021','RECOALCAECALPHISYMDR3','ALCAECALPHISYM']]

### run3 (2022) ###
workflows[140.001] = ['',['RunMinimumBias2022B','HLTRUN3','RECONANORUN3','HARVESTRUN3']]
workflows[140.002] = ['',['RunZeroBias2022B','HLTRUN3','RECONANORUN3','HARVESTRUN3']]
workflows[140.001] = ['',['RunZeroBias2022B','HLTRUN3','RECONANORUN3','HARVESTRUN3']]
Copy link
Contributor

@srimanob srimanob Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to switch the workflow of ZeroBias and MinBias here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, actually this is totally accidental and realized after creating PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, Please fix. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srimanob I made the changes. Please see if these are correctly propagated to the PR.

@srimanob
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39265/31926

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39265 was updated. @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please check and sign again.

@srimanob
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b32d18/27236/summary.html
COMMIT: 87a6342
CMSSW: CMSSW_12_6_X_2022-08-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39265/27236/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 140.56140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log
  • 1001.21001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG/step2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG.log
  • 1002.41002.4_RunDoubleMuon2022B+RunDoubleMuon2022B+TIER0PROMPTRUN3+HARVESTPROMPTRUN3/step2_RunDoubleMuon2022B+RunDoubleMuon2022B+TIER0PROMPTRUN3+HARVESTPROMPTRUN3.log
Expand to see more relval errors ...

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.003_RunJetHT2022B+RunJetHT2022B+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.004_RunEGamma2022B+RunEGamma2022B+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.005_RunSingleMuon2022B+RunSingleMuon2022B+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.015_RunZeroBias2022C+RunZeroBias2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.016_RunJetMET2022C+RunJetMET2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.017_RunEGamma2022C+RunEGamma2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.018_RunMuon2022C+RunMuon2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.019_RunTau2022C+RunTau2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.02_RunBTagMu2022C+RunBTagMu2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.031_RunZeroBias2022D+RunZeroBias2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.032_RunJetMET2022D+RunJetMET2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.033_RunEGamma2022D+RunEGamma2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.034_RunMuon2022D+RunMuon2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.035_RunTau2022D+RunTau2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.036_RunBTagMu2022D+RunBTagMu2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3620448
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3620410
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Sep 1, 2022

It seems to be a glitch on PR test, not relate to this PR. The issue on RelVal-INPUT, as I see 2 of them, they found the file, but did not run until the end.

@srimanob
Copy link
Contributor

srimanob commented Sep 1, 2022

@cmsbuild please test

To see if we can clean up the relval-input issue.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b32d18/27247/summary.html
COMMIT: 87a6342
CMSSW: CMSSW_12_6_X_2022-08-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39265/27247/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.003_RunJetHT2022B+RunJetHT2022B+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.004_RunEGamma2022B+RunEGamma2022B+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.005_RunSingleMuon2022B+RunSingleMuon2022B+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.015_RunZeroBias2022C+RunZeroBias2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.016_RunJetMET2022C+RunJetMET2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.017_RunEGamma2022C+RunEGamma2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.018_RunMuon2022C+RunMuon2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.019_RunTau2022C+RunTau2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.02_RunBTagMu2022C+RunBTagMu2022C+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.031_RunZeroBias2022D+RunZeroBias2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.032_RunJetMET2022D+RunJetMET2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.033_RunEGamma2022D+RunEGamma2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.034_RunMuon2022D+RunMuon2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.035_RunTau2022D+RunTau2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b32d18/140.036_RunBTagMu2022D+RunBTagMu2022D+HLTRUN3+RECONANORUN3+HARVESTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3620448
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3620412
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Sep 1, 2022

+Upgrade

New data workflows run fine.

@kskovpen
Copy link
Contributor

kskovpen commented Sep 1, 2022

+pdmv

Thanks @srimanob for the prompt review!

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 1, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants