Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nT2] DQM for the TOTEM nT2 detector #39159

Merged
merged 2 commits into from
Aug 31, 2022
Merged

[nT2] DQM for the TOTEM nT2 detector #39159

merged 2 commits into from
Aug 31, 2022

Conversation

rozchlastywacz
Copy link
Contributor

PR description:

This PR introduces Data Quality Monitor for T2 telescope.
This code works on top of recently merged PR: #38986

PR validation:

Code compiles and the DQM/CTPPS/test/totemt2_dqm_test_fromdigi_cfg.py test produces DQM root file with plots as expected. Because detector is not yet integrated, test is run on emulated data./store/group/dpg_ctpps/comm_ctpps/TotemT2/RecoTest/emulated_digi_test.root.
Sample plot from DQM output file:
image

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is NOT a backport, but it is intented to be integrated into CMSSW_12_5_X.

@forthommel @grzanka @ChrisMisan for your attention.

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Aug 23, 2022
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39159/31741

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rozchlastywacz (Arkadiusz Ćwikła) for master.

It involves the following packages:

  • DQM/CTPPS (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@fabferro, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@ChrisMisan
Copy link
Contributor

type ctpps, new-feature

@ChrisMisan
Copy link
Contributor

please test

@ChrisMisan
Copy link
Contributor

ChrisMisan commented Aug 23, 2022 •
edited
Loading

@cms-sw/dqm-l2 please consider signing this after tests, it is not changing any of the existing code.

@forthommel
Copy link
Contributor

@civanch the two commits in this PR have been stashed to reflect the history of development for this package.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-902b6c/27032/summary.html
COMMIT: faed243
CMSSW: CMSSW_12_5_X_2022-08-23-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39159/27032/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3693084
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3693054
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@forthommel
DQM: first skeletton of nT2 DQM component
6dc9668 
- added skeletton of T2 segmentation histogram wrapper, and a helper placeholder for the computation of tile bins positions
- added skeletton for the DQM source and test configuration
- added a rechits multiplicity summary monitor
@forthommel
Copy link
Contributor

With #39159 (comment) I rebased this branch to the recently-merged #39140 replacing the digis input collection from an edm::DetSetVector<TotemT2Digi> to a edmNew::DetSetVector<TotemT2Digi>.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39159/31763

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39159/31890

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39159/31892

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39159 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@civanch
Copy link
Contributor

civanch commented Aug 30, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-902b6c/27198/summary.html
COMMIT: 8ffa5e9
CMSSW: CMSSW_12_6_X_2022-08-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39159/27198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3696018
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695984
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • re-sign

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fad126d into cms-sw:master Aug 31, 2022
@forthommel forthommel deleted the ac_nt2_reco_dqm_forpr-12_5_X branch August 31, 2022 08:39
@cmsbuild cmsbuild mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
code-checks-approved ctpps dqm-approved fully-signed new-feature orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_6_X
Development

Successfully merging this pull request may close these issues.
8 participants
@rozchlastywacz @cmsbuild @ChrisMisan @forthommel @emanueleusai @civanch @perrotta @smuzaffar