-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nT2] DQM for the TOTEM nT2 detector #39159
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39159/31741
|
A new Pull Request was created by @rozchlastywacz (Arkadiusz Ćwikła) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type ctpps, new-feature |
please test |
@cms-sw/dqm-l2 please consider signing this after tests, it is not changing any of the existing code. |
@civanch the two commits in this PR have been stashed to reflect the history of development for this package. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-902b6c/27032/summary.html Comparison SummarySummary:
|
- added skeletton of T2 segmentation histogram wrapper, and a helper placeholder for the computation of tile bins positions - added skeletton for the DQM source and test configuration - added a rechits multiplicity summary monitor
faed243
to
2408f43
Compare
With #39159 (comment) I rebased this branch to the recently-merged #39140 replacing the digis input collection from an |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39159/31763
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39159/31890
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
7f6b555
to
8ffa5e9
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39159/31892
|
Pull request #39159 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-902b6c/27198/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR introduces Data Quality Monitor for T2 telescope.
This code works on top of recently merged PR: #38986
PR validation:
Code compiles and the
DQM/CTPPS/test/totemt2_dqm_test_fromdigi_cfg.py
test produces DQM root file with plots as expected. Because detector is not yet integrated, test is run on emulated data./store/group/dpg_ctpps/comm_ctpps/TotemT2/RecoTest/emulated_digi_test.root
.Sample plot from DQM output file:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is NOT a backport, but it is intented to be integrated into CMSSW_12_5_X.
@forthommel @grzanka @ChrisMisan for your attention.