HLT menu development for `12_4_X` (5/N): HLT V1.3 [`12_5_X`] #38816

missirol · 2022-07-21T14:44:51Z

PR description:

Development of HLT menus for CMSSW_12_4_X.

This version of the GRun HLT menu corresponds to HLT V1.3 for 2022 pp data-taking.

This is the PR for the master branch, which will then be backported to 12_4_X (the latter is the release cycle currently used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

CMSHLT-2261: [BPH] added ParkingDoubleMuonLowMass (8 PDs, 4 Streams)
CMSHLT-2273: [BPH] added ParkingDoubleElectronLowMass (6 PDs, 3 Streams)
CMSHLT-2356: [HIG] emu control triggers for 4J2B-PNET triggers
CMSHLT-2357: [HIG] control triggers for boosted Hbb-PNET triggers
CMSHLT-2359: [TSG] cleanup of EventContent of DQM stream
CMSHLT-2362: [BPH] ParkingSingleMuon PD for 2022
CMSHLT-1716: [TSG] set ThroughputService.dqmPathByProcesses to True
CMSHLT-2371: [TSG] backup seeds for Scouting Path
CMSHLT-2358: [JME] added AlCaRawLowPt stream for low pT jets
CMSHLT-2390: [TSG] merging of Muon and JetMET datasets (SingleMuon+DoubleMuon=Muon, JetHT+MET=JetMET)
CMSHLT-2361: [EXO] triggers for displaced dimuons with large lifetimes
CMSHLT-2382: [EXO] backup and monitoring triggers for displaced dimuons with large lifetimes
CMSHLT-2349: [HIG] update of VBF-tau monitoring triggers (mu+tau)
CMSHLT-2398: [JME] changed PS of HLT_Photon30EB_TightID_TightIso from 150 to 6
CMSHLT-2401: [TSG] added drop * statement to AlCaPPS EventContent
CMSHLT-2391: [TSG] cleanup of GRun menu (removal of disabled triggers)
CMSHLT-2404: [RPC] update of maxEta cut in AlCa_RPCMuonNormalisation triggers
CMSHLT-2403: [TSG] re-align offline menu with online (seed and PS of GPU-DQM Paths, splitting of Ephemeral PDs)
CMSHLT-2400: [JME] added PFJet110 control trigger
CMSHLT-2402: [HIG] update of HLTMonitor PD and stream for HLT-PNET monitoring
CMSHLT-2406: [BPH] enable new dimuon exclusive triggers (only for double-muon Parking PDs)
CMSHLT-2407: [TSG] use noise-cleaned e/gamma SigmaIEtaIEta for Scouting

In addition, the input file used for the HLT-Validation tests in IBs is updated to a recent collisions run:
/store/data/Run2022B/HLTPhysics0/RAW/v1/000/355/558/00000/cd851cf4-0fca-4d76-b80e-1d33e1371929.root

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

12_4_X

cmsbuild · 2022-07-21T14:52:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38816/31191

This PR adds an extra 892KB to repository

cmsbuild · 2022-07-21T14:52:57Z

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

missirol · 2022-07-21T14:53:25Z

enable gpu

missirol · 2022-07-21T14:53:46Z

please test

cmsbuild · 2022-07-21T16:09:02Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee54f0/26376/summary.html
COMMIT: 97c73fe
CMSSW: CMSSW_12_5_X_2022-07-21-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38816/26376/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.711634.7_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano.log

RelVals-INPUT

11634.711634.7_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+RecoNano+HARVESTNano.log

GPU Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 3 failed jobs
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19868
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: found differences in 3 / 3 workflows

cmsbuild · 2022-07-21T17:19:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38816/31195

This PR adds an extra 892KB to repository

cmsbuild · 2022-07-21T17:20:21Z

Pull request #38816 was updated. @jpata, @missirol, @cmsbuild, @clacaputo, @Martin-Grunewald can you please check and sign again.

missirol · 2022-07-21T17:21:30Z

please test

The new HLT menu required an update of the function customizeHLTIter0ToMkFit used in wf 11634.7.

@cms-sw/reconstruction-l2 , this PR and its backport (#38817) now require your signature.

cmsbuild · 2022-07-21T21:06:58Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee54f0/26384/summary.html
COMMIT: d9f638e
CMSSW: CMSSW_12_5_X_2022-07-21-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38816/26384/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 3 failed jobs
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 36
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19840
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: found differences in 3 / 3 workflows

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ee54f0/13234.0_TTbar_14TeV+2021FS+TTbar_14TeV_TuneCP5_FastSimRun3+HARVESTFastRun3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ee54f0/13434.0_TTbar_14TeV+2021FSPU+TTbar_14TeV_TuneCP5_FastSimRun3PU+HARVESTFastRun3PU

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 36 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3658754
DQMHistoTests: Total failures: 1549
DQMHistoTests: Total nulls: 55
DQMHistoTests: Total successes: 3657128
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -22599.772 KiB( 50 files compared)
DQMHistoSizes: changed ( 11634.0,... ): -1168.644 KiB HLT/JME
DQMHistoSizes: changed ( 11634.0,... ): -1104.990 KiB HLT/EXO
DQMHistoSizes: changed ( 11634.0,... ): -751.112 KiB HLT/EGM
DQMHistoSizes: changed ( 11634.0,... ): -307.692 KiB HLT/TAU
DQMHistoSizes: changed ( 11634.0,... ): -234.379 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 11634.0,... ): -137.110 KiB HLT/Muon
DQMHistoSizes: changed ( 11634.0,... ): 92.993 KiB HLT/Filters
DQMHistoSizes: changed ( 11634.0,... ): -34.929 KiB HLT/Objects
DQMHistoSizes: changed ( 11634.0,... ): -30.352 KiB HLT/HLTJETMET
DQMHistoSizes: changed ( 11634.0,... ): -29.375 KiB HLT/SUSY
DQMHistoSizes: changed ( 11634.0 ): ...
Checked 210 log files, 47 edm output root files, 51 DQM output files
TriggerResults: found differences in 6 / 50 workflows

missirol · 2022-07-21T21:45:59Z

+hlt

differences in outputs of PR tests are in line with updates to the GRun HLT menu

missirol · 2022-07-21T21:49:08Z

@cms-sw/reconstruction-l2 , please review the minor change in RecoTracker/MkFit added as part of this PR.

HLT would like to have this PR tested in the next IB if possible.

missirol · 2022-07-22T07:51:57Z

I learned that there is some history behind this MkFit customisation, see here and here, incl. an agreement that this customisation should not slow down the integration of HLT updates.

@clacaputo @jpata , please consider reviewing and signing.

@cms-sw/orp-l2 , I ask to consider this PR for the next IB regardless of the RECO signature (based on the aforementioned agreement). I would prefer to have this PR merged by 11:00, because another HLT PR needs to be prepared on top of this one (but not backported, unlike this one).

clacaputo · 2022-07-22T10:57:17Z

+reconstruction

cmsbuild · 2022-07-22T10:57:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

missirol · 2022-07-22T15:50:56Z

@cms-sw/orp-l2 , a kind ping for the review of this PR.

HLT would like to test this in the next IB (23:00).

perrotta · 2022-07-22T17:29:41Z

+1

HLT menu development for 12_4_X (branch: 12_5_X)

97c73fe

cmsbuild added this to the CMSSW_12_5_X milestone Jul 21, 2022

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures tests-pending labels Jul 21, 2022

missirol mentioned this pull request Jul 21, 2022

HLT menu development for 12_4_X (5/N): HLT V1.3 #38817

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 21, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 21, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 21, 2022

update of customizeHLTIter0ToMkFit

d9f638e

cmsbuild added code-checks-pending reconstruction-pending tests-pending and removed tests-rejected code-checks-approved labels Jul 21, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 21, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 21, 2022

missirol changed the title ~~HLT menu development for 12_4_X (5/N): HLT V1.3~~ HLT menu development for 12_4_X (5/N): HLT V1.3 [12_5_X] Jul 21, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 21, 2022

cmsbuild added hlt-approved and removed hlt-pending labels Jul 21, 2022

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Jul 22, 2022

cmsbuild added orp-approved and removed orp-pending labels Jul 22, 2022

cmsbuild merged commit de7e909 into cms-sw:master Jul 22, 2022

missirol deleted the HLTdevelopment124X_for125X branch July 22, 2022 17:44

cmsbuild mentioned this pull request Jul 22, 2022

Add wfs to test Run3 skims #38830

Merged

missirol mentioned this pull request Apr 30, 2023

remove 2022 HLT menu from CMSSW_13_X_Y #41471

Merged

This was referenced May 12, 2023

remove 2022 HLT menu from CMSSW_13_X_Y [13_1_X] #41648

Merged

remove 2022 HLT menu from CMSSW_13_X_Y [13_0_X] #41663

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HLT menu development for `12_4_X` (5/N): HLT V1.3 [`12_5_X`] #38816

HLT menu development for `12_4_X` (5/N): HLT V1.3 [`12_5_X`] #38816

missirol commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

missirol commented Jul 21, 2022

missirol commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

missirol commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

missirol commented Jul 21, 2022

missirol commented Jul 21, 2022

missirol commented Jul 22, 2022

clacaputo commented Jul 22, 2022

cmsbuild commented Jul 22, 2022

missirol commented Jul 22, 2022

perrotta commented Jul 22, 2022

HLT menu development for 12_4_X (5/N): HLT V1.3 [12_5_X] #38816

HLT menu development for 12_4_X (5/N): HLT V1.3 [12_5_X] #38816

Conversation

missirol commented Jul 21, 2022

PR description:

PR validation:

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

missirol commented Jul 21, 2022

missirol commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

RelVals

RelVals-INPUT

GPU Comparison Summary

cmsbuild commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

missirol commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

GPU Comparison Summary

Comparison Summary

missirol commented Jul 21, 2022

missirol commented Jul 21, 2022

missirol commented Jul 22, 2022

clacaputo commented Jul 22, 2022

cmsbuild commented Jul 22, 2022

missirol commented Jul 22, 2022

perrotta commented Jul 22, 2022

HLT menu development for `12_4_X` (5/N): HLT V1.3 [`12_5_X`] #38816

HLT menu development for `12_4_X` (5/N): HLT V1.3 [`12_5_X`] #38816