Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v17 Partial wafer implementation #37787

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

Pruthvi-ch
Copy link
Contributor

PR description:

There will no changes in the output.
It depends on PR: https://github.com/cms-sw/cmssw/pull/37664
This is related to partial wafer implementation in v17 for HGCAL, using same placement index notation as full wafers

PR validation:

Use runTheMatrix test workflows 'runTheMatrix.py -l limited -i all --ibeos'
Specific cfg's in Geometry/HGCalCommonData/test/python/dumpHGCalWaferPRDDD_cfi.py to dump geometry view using fireworks

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37787/29696

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2022

A new Pull Request was created by @Pruthvi-ch for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@trtomei, @bsunanda, @beaucero, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor

bsunanda commented May 4, 2022

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cd954/24430/summary.html
COMMIT: e63cd75
CMSSW: CMSSW_12_4_X_2022-05-03-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37787/24430/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3700548
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3700518
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented May 4, 2022

+1

@AdrianoDee
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 5, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants