Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.3.X] Bugfix for Strips O2O #37235

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 14, 2022

PR description:

Fix for #37228

PR validation:

Using CondTools/SiStrip/scripts/o2oRun_SiStripDAQ.py 1 /cvmfs/cms.cern.ch/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_1/src/CondTools/SiStrip/python/SiStripDCS_popcon.py --debug --db sqlite:test.db I can reproduce the issue in #37228

After this PR the error is gone.
(and I get the msg that Exception: Database 'sqlite:test.db' is not known. which is fine since I anyway didnt want to upload to the DB)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37230

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

  • CondTools/SiStrip (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 14, 2022

@quinnanm @rgerosa

@mmusich
Copy link
Contributor Author

mmusich commented Mar 14, 2022

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Mar 14, 2022

type bug-fix

@perrotta
Copy link
Contributor

backport of #37230

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ed981/23086/summary.html
COMMIT: d30ceca
CMSSW: CMSSW_12_3_X_2022-03-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37235/23086/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695131
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 14, 2022

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Master version succesfully merged in CMSSW_12_4_X_2022-03-14-1100

@cmsbuild cmsbuild merged commit ebad739 into cms-sw:CMSSW_12_3_X Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants