Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include HLT JEC and L1T Menu tags in data, mcRun3 and mcRun4 GTs #37144

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented Mar 4, 2022

PR description:

This PR is to include:

The L1T menu tag included in the MC GTs is:
L1Menu_Collisions2022_v0_1_6_xml

The HLT JEC tags included in data are:
Label: AK4CaloHLT , Tag: JetCorrectorParametersCollection_AK4CaloHLT_hlt_v1
Label: AK4PFClusterHLT , Tag: JetCorrectorParametersCollection_AK4PFClusterHLT_hlt_v1
Label: AK4PFHLT , Tag: JetCorrectorParametersCollection_AK4PFHLT_hlt_v1
Label: AK4PFPuppiHLT , Tag: JetCorrectorParametersCollection_AK4PFPuppiHLT_hlt_v1
Label: AK4PFchsHLT , Tag: JetCorrectorParametersCollection_AK4PFchsHLT_hlt_v1
Label: AK8CaloHLT , Tag: JetCorrectorParametersCollection_AK8CaloHLT_hlt_v1
Label: AK8PFClusterHLT , Tag: JetCorrectorParametersCollection_AK8PFClusterHLT_hlt_v1
Label: AK8PFHLT , Tag: JetCorrectorParametersCollection_AK8PFHLT_hlt_v1
Label: AK8PFPuppiHLT , Tag: JetCorrectorParametersCollection_AK8PFPuppiHLT_hlt_v1
Label: AK8PFchsHLT , Tag: JetCorrectorParametersCollection_AK8PFchsHLT_hlt_v1

The HLT JEC tags included in MC are:
Label: AK4CaloHLT , Tag: JetCorrectorParametersCollection_Run3Winter21_V2_MC_AK4CaloHLT
Label: AK4PFClusterHLT , Tag: JetCorrectorParametersCollection_Run3Winter21_V2_MC_AK4PFClusterHLT
Label: AK4PFHLT , Tag: JetCorrectorParametersCollection_Run3Winter21_V2_MC_AK4PFHLT
Label: AK4PFPuppiHLT , Tag: JetCorrectorParametersCollection_Run3Winter21_V2_MC_AK4PFPuppiHLT
Label: AK4PFchsHLT , Tag: JetCorrectorParametersCollection_Run3Winter21_V2_MC_AK4PFchsHLT
Label: AK8CaloHLT , Tag: JetCorrectorParametersCollection_Run3Winter21_V2_MC_AK8CaloHLT
Label: AK8PFClusterHLT , Tag: JetCorrectorParametersCollection_Run3Winter21_V2_MC_AK8PFClusterHLT
Label: AK8PFHLT , Tag: JetCorrectorParametersCollection_Run3Winter21_V2_MC_AK8PFHLT
Label: AK8PFPuppiHLT , Tag: JetCorrectorParametersCollection_Run3Winter21_V2_MC_AK8PFPuppiHLT
Label: AK8PFchsHLT , Tag: JetCorrectorParametersCollection_Run3Winter21_V2_MC_AK8PFchsHLT

The differences in GTs are only related to the JEC and L1T tags, as can be seen below:
run3_data_prompt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Prompt_v5/123X_dataRun3_Prompt_v4

run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_v4/123X_dataRun3_v3

phase1_2021_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2021_design_v11/123X_mcRun3_2021_design_v10

phase1_2021_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2021_realistic_v11/123X_mcRun3_2021_realistic_v10

phase1_2021_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2021cosmics_realistic_deco_v11/123X_mcRun3_2021cosmics_realistic_deco_v10

phase1_2021_realistic_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2021_realistic_HI_v11/123X_mcRun3_2021_realistic_HI_v10

phase1_2023_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2023_realistic_v11/123X_mcRun3_2023_realistic_v10

phase1_2024_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2024_realistic_v11/123X_mcRun3_2024_realistic_v10

phase2_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun4_realistic_v8/123X_mcRun4_realistic_v7

PR validation:

nohup runTheMatrix.py -l 138.4,139.002,12034.0,11634.0,7.23,159.0,12434.0,12834.0 --ibeos -j16

if this PR is a backport please specify the original PR and why you need to backport that PR:

not a backport

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37144/28686

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2022

A new Pull Request was created by @malbouis for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

malbouis commented Mar 4, 2022

test parameters:

  • workflows=138.4,139.002,12034.0,7.23,159.0,12834.0

@malbouis
Copy link
Contributor Author

malbouis commented Mar 4, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8f4ce/22852/summary.html
COMMIT: 88cfed2
CMSSW: CMSSW_12_3_X_2022-03-04-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37144/22852/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a8f4ce/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a8f4ce/139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a8f4ce/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3987741
  • DQMHistoTests: Total failures: 13007
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3974712
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 48 workflows

@tvami
Copy link
Contributor

tvami commented Mar 4, 2022

+alca

  • changes all over the place (HLT folder, jet and trigger related plots), as expected from this update

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 5, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants