Technical fixes for geometry DB payload creation #36897
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36897/28172
|
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages:
@malbouis, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @ggovi, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -27,10 +27,13 @@ class CSCGeometryAnalyzer : public edm::one::EDAnalyzer<> { | |||
| const int dashedLineWidth_; | |||
| const std::string dashedLine_; | |||
| const std::string myName_; | |||
| edm::ESGetToken<CSCGeometry, MuonGeometryRecord> ddToken_; | |||
There was a problem hiding this comment.
| edm::ESGetToken<CSCGeometry, MuonGeometryRecord> ddToken_; | |
| const edm::ESGetToken<CSCGeometry, MuonGeometryRecord> ddToken_; |
| @@ -42,8 +45,7 @@ void CSCGeometryAnalyzer::analyze(const edm::Event& iEvent, const edm::EventSetu | |||
| std::cout << "start " << dashedLine_ << std::endl; | |||
| std::cout << "pi = " << dPi << ", radToDeg = " << radToDeg << std::endl; | |||
|
|
|||
| edm::ESHandle<CSCGeometry> pDD; | |||
| iSetup.get<MuonGeometryRecord>().get(pDD); | |||
| edm::ESTransientHandle<CSCGeometry> pDD = iSetup.getTransientHandle(ddToken_); | |||
There was a problem hiding this comment.
I think this can be const too
There was a problem hiding this comment.
@tvami Thanks for the suggestions. I made those changes.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36897/28173
|
|
Pull request #36897 was updated. @malbouis, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @ggovi, @tvami, @francescobrivio can you please check and sign again. |
|
@cmsbuild please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd7f16/22240/summary.html Comparison SummarySummary:
|
|
+1 |
|
I see the vertex collection changed for 2026D88 |
|
+db
|
|
+Upgrade Technical PR for payload creation. |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1
|
This PR is a collection of fixes and enhancements to support geometry DB payload creation. The changes are as follows.
CondTools/Geometry/test/writehelpers/geometryExtended2021_writer.py-- remove improper DD4hep dependence from this DDD script.DetectorDescription/OfflineDBLoader/plugins/OutputDDToDDL.cc-- fix to prevent run-time error related to Event Setup.Geometry/CSCGeometry/test/stubs/CSCGeometryAnalyzer.cc-- ES Get Token migration to allow CSC geometry test to run in 12_3.Geometry/GEMGeometry/test/testGEMGeometry_cfg.pyGeometry/GEMGeometry/test/testGEMGeometryFromDB_cfg.pyGeometry/GEMGeometry/test/testGEMGeometryFromLocalDB_cfg.py-- scripts to help compare GEM reco geometry in XML, DB, and a local DB.None of the files in this PR are used by any workflow. They are only used for expert tools.
PR validation:
DDD DB payloads were created succesfully to verify the changes in this PR. Also, the test scripts were run, and they produce reasonable output.
if this PR is a backport please specify the original PR and why you need to backport that PR:
A backport to 12_2 would promote consistency but it is not strictly necessary. I can manually copy these changes to a 12_2 working directory if it turns out I need them.