Fix accessing one-past-the-end element

[fwyzard]

PR description:

Fix writing to one-past-the-end element in HLTLogMonitorFilter.

PR validation:

Runing the unit tests in the ASAN IB no longer gives any errors.

[fwyzard]

please test

[fwyzard]

type bugfix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36738/27839

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• HLTrigger/special (hlt)

@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15b16c/21780/summary.html
COMMIT: e147992
CMSSW: CMSSW_12_3_X_2022-01-18-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36738/21780/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3464860
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3464833
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[missirol]

please test for CMSSW_12_3_ASAN_X

As noted in other PRs, the error from wf 4.76 is unrelated. The relevant unit test in HLTrigger/special passed as expected. Testing then with an ASAN build, we can verify that this resolves #36729.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15b16c/21799/summary.html
COMMIT: e147992
CMSSW: CMSSW_12_3_ASAN_X_2022-01-17-2300/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36738/21799/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 73 failed jobs
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3464860
• DQMHistoTests: Total failures: 1064499
• DQMHistoTests: Total nulls: 64
• DQMHistoTests: Total successes: 2400275
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 3.41 KiB( 42 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.117 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 3.240 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 0.533 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.246 KiB SiStrip/MechanicalView
• Checked 181 log files, 42 edm output root files, 43 DQM output files

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• This fix only affects the HLTLogMonitorFilter unit test, while it does not affect any other workflow. It can therefore be safely merged in pre4, even if we don't want any additional code or configuration change in it besides the updated/fixed run3 geometry. (And by merging it we can start shortening the queue of pending PRs while waiting for the geometry related PRs to converge....)

[perrotta]

merge