Modernize most legacy EDModules in TopQuarkAnalysis package

[makortel]

PR description:

Part of #36404. Modernization includes

• Move contents of plugin headers to source files
• Use thread-efficient EDModule base classes
• Use of std::unique_ptr instead of raw pointers
• Use of Event::get() instead of Event::getByToken() (not everywhere though)

Notable EDModules left to legacy (of which TtFullLepKinSolutionProducer. is being run in IB tests according to #36404 (comment))

• TtSemiEvtSolutionMaker
  • Uses TtSemiLRJetCombCalc that uses LRHelpFunctions that calls gStyle->Set.... Migrating this would need domain knowledge.
• TtHadEvtSolutionMaker
  • Uses TtHadLRJetCombCalc that uses LRHelpFunctions (see above)
• TtDilepEvtSolutionMaker
  • Uses TtHadEvtSolutionMaker that calls TF2::Eval(). The TF1::Eval() can be made thread friendly if the TF1 is not added to the global list of functions (see e.g. Do not put temporary TF1 into ROOT's global function pool #18636), but quickly I didn't see similar option for TF2.
• TtFullLepKinSolutionProducer.
  • Calls TF2::Ecval() (see above)

These are left to be followed up later (I'll probably open a new issue with the information above).

PR validation:

Unit tests pass.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36692/27758

• This PR adds an extra 176KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36692/27758/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36692/27758/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36692/27759

• This PR adds an extra 176KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• AnalysisDataFormats/TopObjects (analysis)
• TopQuarkAnalysis/TopEventProducers (analysis)
• TopQuarkAnalysis/TopHitFit (analysis)
• TopQuarkAnalysis/TopJetCombination (analysis)
• TopQuarkAnalysis/TopKinFitter (analysis)
• TopQuarkAnalysis/TopObjectResolutions (analysis)
• TopQuarkAnalysis/TopSkimming (analysis)
• TopQuarkAnalysis/TopTools (analysis)

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cee146/21659/summary.html
COMMIT: 0251b28
CMSSW: CMSSW_12_3_X_2022-01-11-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36692/21659/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36692/27775

• This PR adds an extra 184KB to repository

[cmsbuild]

Pull request #36692 was updated. @cmsbuild, @santocch can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cee146/21699/summary.html
COMMIT: 002c1f2
CMSSW: CMSSW_12_3_X_2022-01-12-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36692/21699/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 3 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cee146/21699/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461659
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3461626
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• (Bypassing analysis signature)

[perrotta]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.