-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize most legacy EDModules in TopQuarkAnalysis package #36692
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36692/27758
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Add "SERIAL" to the TH1::Fit() calls to make the calls thread friendly.
… TopKinFitter List of classes: - TtFullHadKinFitProducer - TtFullLepKinSolutionProducer - TtSemiLepKinFitProducer
List of classes - TtFullHadKinFitProducer - TtSemiLepKinFitProducer
d718b47
to
0251b28
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36692/27759
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@cmsbuild, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
0251b28
to
e895d53
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36692/27775
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cee146/21699/summary.html CMS StaticAnalyzer warnings: There are 3 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cee146/21699/llvm-analysis/legacy-mod-sa.txt for details. Comparison SummarySummary:
|
+1
|
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Part of #36404. Modernization includes
std::unique_ptr
instead of raw pointersEvent::get()
instead ofEvent::getByToken()
(not everywhere though)Notable EDModules left to legacy (of which
TtFullLepKinSolutionProducer.
is being run in IB tests according to #36404 (comment))TtSemiEvtSolutionMaker
TtSemiLRJetCombCalc
that usesLRHelpFunctions
that callsgStyle->Set...
. Migrating this would need domain knowledge.TtHadEvtSolutionMaker
TtHadLRJetCombCalc
that usesLRHelpFunctions
(see above)TtDilepEvtSolutionMaker
TtHadEvtSolutionMaker
that callsTF2::Eval()
. TheTF1::Eval()
can be made thread friendly if theTF1
is not added to the global list of functions (see e.g. Do not put temporary TF1 into ROOT's global function pool #18636), but quickly I didn't see similar option forTF2
.TtFullLepKinSolutionProducer.
TF2::Ecval()
(see above)These are left to be followed up later (I'll probably open a new issue with the information above).
PR validation:
Unit tests pass.