fixes for recent updates to CkfTrackCandidateMaker

[missirol]

PR description:

This PR is a follow-up of #36459:

• it fixes a failure in wf 11723.17;
• it removes unneeded type-specifications for parameters values of cloned modules, addressing add fillDescriptions to CkfTrackCandidateMaker (and its dependencies) #36459 (comment).

Merely technical. No changes expected.

PR validation:

runTheMatrix.py (for -l limited and -l 11723.17), and addOnTests.py passed.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36658/27690

• This PR adds an extra 76KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• RecoHI/HiTracking (reconstruction)
• RecoTracker/CkfPattern (reconstruction)
• RecoTracker/ConversionSeedGenerators (reconstruction)
• RecoTracker/IterativeTracking (reconstruction)
• RecoTracker/SpecialSeedGenerators (reconstruction)
• TrackingTools/GsfTracking (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @jazzitup, @VinInn, @bellan, @yenjie, @ebrondol, @rovere, @lecriste, @kurtejung, @gpetruc, @mmusich, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[missirol]

type bugfix

[missirol]

test parameters:

• workflows = 11723.17

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-583a82/21582/summary.html
COMMIT: 47e9d58
CMSSW: CMSSW_12_3_X_2022-01-09-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36658/21582/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-583a82/11723.17_QCD_Pt_1800_2400_14+2021_seedingDeepCore+QCD_Pt_1800_2400_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461659
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3461637
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[jpata]

Is this removed because the default value for CkfTrajectoryBuilder.maxPtForLooperReconstruction is already 0.0? Is it foreseen that default tracking and deepcore may end up using different thresholds, so it might be better to keep this?

[missirol]

I think it must be removed b/c TrajectoryBuilderForElectrons is a CkfTrajectoryBuilder, and that does not use a parameter maxPtForLooperReconstruction (only GroupedCkfTrajectoryBuilder does). This also implies that these two lines were not having any effect up to now (the parameter wasn't actually being used).

[missirol]

To be clearer (maybe I was not): this one update is the one that fixes the unit test (b/c TrajectoryBuilderForElectrons.maxPtForLooperReconstruction is invalid); it is not related to the "drop type-specs" updates.

[missirol]

Here, too, the parameter is removed b/c GroupedCkfTrajectoryBuilder does not have/use a parameter named clustersToSkip.

[jpata]

+reconstruction

• technical, drop type specs in python
• also a bugfix for the recently uncovered Configuration error in workflow 11723.17 #36665
• no reco change expected or observed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1