-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new oneapi naming #36568
Migrate to new oneapi naming #36568
Conversation
Changed includes to use new header path for TBB
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36568/27517
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
7c69418
to
6cf8c1a
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36568/27519
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the plain tbb::
is going to be deprecated/removed at some point. For future reference, do you know when?
/* Copied from tbb_2020 branch's oneapi/tbb/tbb_allocator linked here | ||
https://github.com/oneapi-src/oneTBB/blob/tbb_2020/include/oneapi/tbb/tbb_allocator.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be kept without oneapi
/* Copied from tbb_2020 branch's oneapi/tbb/tbb_allocator linked here | |
https://github.com/oneapi-src/oneTBB/blob/tbb_2020/include/oneapi/tbb/tbb_allocator.h | |
/* Copied from tbb_2020 branch's tbb/tbb_allocator linked here | |
https://github.com/oneapi-src/oneTBB/blob/tbb_2020/include/tbb/tbb_allocator.h |
and renamed to edm namespace because it was removed from oneapi_2021 branch's | ||
tbb/tbb_allocator. | ||
oneapi/tbb/tbb_allocator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this too?
oneapi/tbb/tbb_allocator. | |
tbb/tbb_allocator. |
From their documentation, they always say to use |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36568/27521
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57258a/21433/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
enable threading |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57258a/21446/summary.html Comparison SummarySummary:
|
The compiler generates the same code with our without this change. In the TBB code itself, |
@Dr15Jones if this relates to my observation above: yes. I see that this is a purely technical update that cannot originate those differences. I just wanted to pinpoint it to warn the potentially affected experts of a possible non-reproducibility issue. In another thread @slava77 reminded me that what I reported here is a know issue for running on different architectures |
+1
|
Did this cause the break in CXXMODULE IB?
|
PR description:
PR validation:
Code compiles.